Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: mojo/public/python/mojo_bindings/serialization.py

Issue 939083002: Fix version handling for boolean groups. (Closed) Base URL: https://github.com/domokit/mojo.git@fix_apk_update
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/python/mojo_bindings/descriptor.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/python/mojo_bindings/serialization.py
diff --git a/mojo/public/python/mojo_bindings/serialization.py b/mojo/public/python/mojo_bindings/serialization.py
index 2e887c283f3855491c2807be114abdfdf5731fbc..8f5cc67b515a7451466748e30889b3676faa337c 100644
--- a/mojo/public/python/mojo_bindings/serialization.py
+++ b/mojo/public/python/mojo_bindings/serialization.py
@@ -170,11 +170,12 @@ def NeededPaddingForAlignment(value, alignment=8):
def _GetVersion(groups):
if not len(groups):
return 0
- return max([x.version for x in groups])
+ return max([x.GetMaxVersion() for x in groups])
def _FilterGroups(groups, version):
- return [group for group in groups if group.GetVersion() <= version]
+ return [group.Filter(version) for
+ group in groups if group.GetMinVersion() <= version]
def _GetStruct(groups):
« no previous file with comments | « mojo/public/python/mojo_bindings/descriptor.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698