Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9390038: Move automation/ui_controls to ui/ui_controls (Closed)

Created:
8 years, 10 months ago by oshima
Modified:
8 years, 9 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews, asanka, James Su, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, kkania, yoshiki+watch_chromium.org, Randy Smith (Not in Mondays), yuzo+watch_chromium.org, davidbarr+watch_chromium.org, robertshield, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, dcheng, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

* Move automation/ui_controls to ui/ui_controls * Refactored aura impl so that ui/ui_controls doesn't depend on aura. * Moved MoveMouseToCenterAndPress to ui_test_util.h as it depends on views and can't be declared in ui. * a couple of cleanups: - Renamed gtk_screen_utils.h to _util.h to match other util.h files. - indent fix - remove unnecessary includes. This CL allows a test to use ui_controls without depending on chrome. BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : win_aura fix #

Patch Set 4 : fix win_aura build #

Patch Set 5 : cleanup #

Patch Set 6 : sync #

Total comments: 1

Patch Set 7 : addressed issue, fixed comment #

Patch Set 8 : sync #

Patch Set 9 : win_aura fix, sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+908 lines, -1980 lines) Patch
M ash/shell.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_gtk.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/automation/ui_controls.h View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/automation/ui_controls_aurawin.cc View 1 2 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/automation/ui_controls_aurax11.cc View 1 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/browser/automation/ui_controls_gtk.cc View 1 chunk +0 lines, -322 lines 0 comments Download
D chrome/browser/automation/ui_controls_internal.h View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/automation/ui_controls_internal.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/automation/ui_controls_internal_win.cc View 1 2 1 chunk +0 lines, -352 lines 0 comments Download
D chrome/browser/automation/ui_controls_mac.mm View 1 chunk +0 lines, -387 lines 0 comments Download
D chrome/browser/automation/ui_controls_win.cc View 1 2 1 chunk +0 lines, -75 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud_uitest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/confirm_bubble_view.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_shelf_gtk.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_util.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 1 2 3 chunks +2 lines, -32 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc View 1 2 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_view_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 2 43 chunks +48 lines, -43 lines 0 comments Download
M chrome/browser/ui/views/button_dropdown_test.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/menu_item_view_test.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/menu_model_adapter_test.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller2_interactive_uitest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 2 4 chunks +31 lines, -3 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 3 chunks +13 lines, -1 line 0 comments Download
M chrome/test/base/ui_test_utils_aura.cc View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils_gtk.cc View 1 2 5 chunks +61 lines, -4 lines 0 comments Download
M chrome/test/base/ui_test_utils_mac.mm View 1 2 3 chunks +27 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils_win.cc View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/web_drag_dest_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/web_drag_source_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
A ui/aura/ui_controls_aura.h View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A ui/aura/ui_controls_win.cc View 1 2 3 4 5 6 7 8 1 chunk +85 lines, -0 lines 0 comments Download
A ui/aura/ui_controls_x11.cc View 1 2 3 4 1 chunk +238 lines, -0 lines 0 comments Download
A + ui/base/gtk/gtk_screen_util.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
A ui/base/gtk/gtk_screen_util.cc View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
D ui/base/gtk/gtk_screen_utils.h View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
ui/base/gtk/gtk_screen_utils.cc View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
M ui/ui.gyp View 1 2 3 4 5 3 chunks +11 lines, -2 lines 0 comments Download
A + ui/ui_controls/ui_controls.h View 1 2 4 chunks +34 lines, -45 lines 0 comments Download
A ui/ui_controls/ui_controls_aura.h View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
A ui/ui_controls/ui_controls_aura.cc View 1 2 3 4 5 6 1 chunk +83 lines, -0 lines 0 comments Download
A + ui/ui_controls/ui_controls_gtk.cc View 1 2 3 chunks +3 lines, -62 lines 0 comments Download
A ui/ui_controls/ui_controls_internal_win.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A + ui/ui_controls/ui_controls_internal_win.cc View 1 2 3 chunks +2 lines, -7 lines 0 comments Download
A + ui/ui_controls/ui_controls_mac.mm View 1 2 4 chunks +4 lines, -31 lines 0 comments Download
A + ui/ui_controls/ui_controls_win.cc View 1 2 2 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
8 years, 9 months ago (2012-03-15 01:05:56 UTC) #1
sky
LGTM, but can you make sure this works for Elliot too (I've added him as ...
8 years, 9 months ago (2012-03-15 15:04:36 UTC) #2
Elliot Glaysher
i don't see a problem with this. lgtm.
8 years, 9 months ago (2012-03-15 16:52:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/9390038/70134
8 years, 9 months ago (2012-03-16 04:32:53 UTC) #4
commit-bot: I haz the power
Can't process patch for file ui/base/gtk/gtk_screen_utils.cc. File's status is None, patchset upload is incomplete.
8 years, 9 months ago (2012-03-16 04:33:02 UTC) #5
oshima
8 years, 9 months ago (2012-03-16 07:30:37 UTC) #6 
On 2012/03/16 04:33:02, I haz the power (commit-bot) wrote:
> Can't process patch for file ui/base/gtk/gtk_screen_utils.cc.
> File's status is None, patchset upload is incomplete.

I couldn't figure out how to fix this. I created another CL to submit.

http://codereview.chromium.org/9699098

Powered by Google App Engine
This is Rietveld 408576698