Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 938943002: Allow GrGpuResources' unique keys to be changed. (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@rename
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Allow resources' unique keys to be changed. Committed: https://skia.googlesource.com/skia/+/f99e961f55bb603d099c8cb57d05a2ae52a4e9ca

Patch Set 1 #

Patch Set 2 : add a test case #

Total comments: 6

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -82 lines) Patch
M include/gpu/GrContext.h View 1 chunk +4 lines, -3 lines 0 comments Download
M include/gpu/GrGpuResource.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrResourceKey.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 1 chunk +6 lines, -14 lines 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/GrGpuResourcePriv.h View 1 2 1 chunk +7 lines, -9 lines 0 comments Download
M src/gpu/GrResourceCache.h View 1 2 3 chunks +11 lines, -15 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 chunk +34 lines, -10 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 5 chunks +52 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bsalomon
5 years, 10 months ago (2015-02-19 04:37:06 UTC) #2
robertphillips
lgtm + nits https://codereview.chromium.org/938943002/diff/20001/src/gpu/GrResourceCache.h File src/gpu/GrResourceCache.h (right): https://codereview.chromium.org/938943002/diff/20001/src/gpu/GrResourceCache.h#newcode302 src/gpu/GrResourceCache.h:302: void changeUniqueKey(GrGpuResource* resource, const GrUniqueKey& newKey) ...
5 years, 10 months ago (2015-02-19 15:25:53 UTC) #3
bsalomon
https://codereview.chromium.org/938943002/diff/20001/src/gpu/GrResourceCache.h File src/gpu/GrResourceCache.h (right): https://codereview.chromium.org/938943002/diff/20001/src/gpu/GrResourceCache.h#newcode302 src/gpu/GrResourceCache.h:302: void changeUniqueKey(GrGpuResource* resource, const GrUniqueKey& newKey) { On 2015/02/19 ...
5 years, 10 months ago (2015-02-19 15:33:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938943002/40001
5 years, 10 months ago (2015-02-19 15:35:05 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 16:24:21 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f99e961f55bb603d099c8cb57d05a2ae52a4e9ca

Powered by Google App Engine
This is Rietveld 408576698