quic_client should check return codes when parsing command-line flags.

quic_client should check return codes when parsing command-line flags.

This is a minimal fix to prevent silently doing the wrong thing.
A better fix would resolve names, and use the URL itself as a fallback.

BUG=none

Committed: https://crrev.com/5ec46dd5b1a8840be3dbd8800419736a40a85bd9
Cr-Commit-Position: refs/heads/master@{#316925}

[dougk, 2015-02-18 22:40:53]

dougk@chromium.org changed reviewers:
+ rch@chromium.org, rtenneti@google.com

[ramant (doing other things), 2015-02-18 23:10:21]

rtenneti@chromium.org changed reviewers:
+ rtenneti@chromium.org

[ramant (doing other things), 2015-02-18 23:10:21]

lgtm

[dougk, 2015-02-18 23:17:03]

The CQ bit was checked by dougk@chromium.org

[commit-bot: I haz the power, 2015-02-18 23:18:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/938853002/1

[Ryan Hamilton, 2015-02-18 23:51:13]

Two nits.

https://codereview.chromium.org/938853002/diff/1/net/quic/quic_server_bin.cc
File net/quic/quic_server_bin.cc (right):

https://codereview.chromium.org/938853002/diff/1/net/quic/quic_server_bin.cc#...
net/quic/quic_server_bin.cc:56: return 1;
Early return please:

if (!base::StringToInt()) {
  std::cerr <<;
  return 1;
}
FLAGS_port = port;

(Also it looks like you could just use &FLAGS_port in your call to StringToInt)

https://codereview.chromium.org/938853002/diff/1/net/tools/quic/quic_client_b...
File net/tools/quic/quic_client_bin.cc (right):

https://codereview.chromium.org/938853002/diff/1/net/tools/quic/quic_client_b...
net/tools/quic/quic_client_bin.cc:133: return 1;
Early return please:

if (!base::StringToInt()) {
  std::cerr <<;
  return 1;
}
FLAGS_port = port;

[commit-bot: I haz the power, 2015-02-18 23:54:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-18 23:55:30]

Patchset 1 (id:??) landed as
https://crrev.com/5ec46dd5b1a8840be3dbd8800419736a40a85bd9
Cr-Commit-Position: refs/heads/master@{#316925}

[dougk, 2015-02-19 00:29:19]

new commit - https://codereview.chromium.org/934383002/

https://codereview.chromium.org/938853002/diff/1/net/quic/quic_server_bin.cc
File net/quic/quic_server_bin.cc (right):

https://codereview.chromium.org/938853002/diff/1/net/quic/quic_server_bin.cc#...
net/quic/quic_server_bin.cc:56: return 1;
On 2015/02/18 23:51:13, Ryan Hamilton wrote:
> Early return please:
> 
> if (!base::StringToInt()) {
>   std::cerr <<;
>   return 1;
> }
> FLAGS_port = port;
> 
> (Also it looks like you could just use &FLAGS_port in your call to
StringToInt)

Done.

https://codereview.chromium.org/938853002/diff/1/net/tools/quic/quic_client_b...
File net/tools/quic/quic_client_bin.cc (right):

https://codereview.chromium.org/938853002/diff/1/net/tools/quic/quic_client_b...
net/tools/quic/quic_client_bin.cc:133: return 1;
On 2015/02/18 23:51:13, Ryan Hamilton wrote:
> Early return please:
> 
> if (!base::StringToInt()) {
>   std::cerr <<;
>   return 1;
> }
> FLAGS_port = port;

Done.