quic_client should check return codes when parsing command-line flags.

net/quic/quic_server_bin.cc

Index: net/quic/quic_server_bin.cc
diff --git a/net/quic/quic_server_bin.cc b/net/quic/quic_server_bin.cc
index 320f3dac458fa99064a7c9bfbbab53fac5ee3758..e7c2a6ca04afdd6d4e13a3ec98b5369b43c9338b 100644
--- a/net/quic/quic_server_bin.cc
+++ b/net/quic/quic_server_bin.cc
@@ -51,6 +51,9 @@ int main(int argc, char *argv[]) {
     int port;
     if (base::StringToInt(line->GetSwitchValueASCII("port"), &port)) {
       FLAGS_port = port;
+    } else {
+      LOG(ERROR) << "--port must be an integer\n";
+      return 1;

[Ryan Hamilton, 2015/02/18 23:51:13]

Early return please:

if (!base::StringToInt()) {
  std::cerr <<;
  return 1;
}
FLAGS_port = port;

(Also it looks like you could just use &FLAGS_port in your call to StringToInt)

[dougk, 2015/02/19 00:29:19]

Done.

     }
   }