Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Issue 938843002: PPAPI: Don't use MessageLoop::current in the plugin process (Closed)

Created:
5 years, 10 months ago by dmichael (off chromium)
Modified:
5 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PPAPI: Don't use MessageLoop::current in the plugin process The plugin is allowed to use Pepper without having bound a PPB_MessageLoop to the calling thread, which means MessageLoop::current won't be valid. Instead, we should just post to the Pepper main thread. BUG=459671 Committed: https://crrev.com/ac860c7f9ad3a532a6cf0684aaa270d9c0ef36a6 Cr-Commit-Position: refs/heads/master@{#316924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ppapi/proxy/ppb_image_data_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/resource_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dmichael (off chromium)
5 years, 10 months ago (2015-02-18 22:00:05 UTC) #2
raymes
On 2015/02/18 22:00:05, dmichael wrote: lgtm
5 years, 10 months ago (2015-02-18 22:16:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938843002/1
5 years, 10 months ago (2015-02-18 22:36:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 23:52:21 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 23:53:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac860c7f9ad3a532a6cf0684aaa270d9c0ef36a6
Cr-Commit-Position: refs/heads/master@{#316924}

Powered by Google App Engine
This is Rietveld 408576698