ppapi/proxy/ppb_var_deprecated_proxy.cc - Issue 938843002: PPAPI: Don't use MessageLoop::current in the plugin process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/ppb_var_deprecated_proxy.cc

Issue 938843002: PPAPI: Don't use MessageLoop::current in the plugin process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/ppb_var_deprecated_proxy.cc

diff --git a/ppapi/proxy/ppb_var_deprecated_proxy.cc b/ppapi/proxy/ppb_var_deprecated_proxy.cc

index 723fb94118647d834c080a330e2776c464b50993..7adda60381b6e5818c338929cc721a07bfd5094f 100644

--- a/ppapi/proxy/ppb_var_deprecated_proxy.cc

+++ b/ppapi/proxy/ppb_var_deprecated_proxy.cc

@@ -22,6 +22,7 @@

#include "ppapi/proxy/ppp_class_proxy.h"

#include "ppapi/proxy/proxy_object_var.h"

#include "ppapi/proxy/serialized_var.h"

+#include "ppapi/shared_impl/ppapi_globals.h"

#include "ppapi/shared_impl/ppb_var_shared.h"

#include "ppapi/shared_impl/proxy_lock.h"

#include "ppapi/shared_impl/var.h"

@@ -379,7 +380,7 @@ void PPB_Var_Deprecated_Proxy::OnMsgReleaseObject(int64 object_id) {

// spurious warning).

// TODO(piman): See if we can fix the IPC code to enforce strict ordering, and

// then remove this.

- base::MessageLoop::current()->PostNonNestableTask(

+ PpapiGlobals::Get()->GetMainThreadMessageLoop()->PostNonNestableTask(

FROM_HERE,

RunWhileLocked(base::Bind(&PPB_Var_Deprecated_Proxy::DoReleaseObject,

task_factory_.GetWeakPtr(),

« no previous file with comments | « ppapi/proxy/ppb_instance_proxy.cc ('k') | ppapi/shared_impl/resource_tracker.cc » ('j') | no next file with comments »