Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1715)

Unified Diff: sync/protocol/app_specifics.proto

Issue 93883004: Sync the launch type pref for apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unfix nit because it prevents testing of how invalid values are handled Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | sync/protocol/proto_enum_conversions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/protocol/app_specifics.proto
diff --git a/sync/protocol/app_specifics.proto b/sync/protocol/app_specifics.proto
index a7f09ec1be197369b5170c402c699554e274acae..374a21928fa38b36d8b04b7576506b9a342edcc9 100644
--- a/sync/protocol/app_specifics.proto
+++ b/sync/protocol/app_specifics.proto
@@ -47,7 +47,7 @@ message AppSpecifics {
optional ExtensionSpecifics extension = 1;
// Notification settings.
- optional AppNotificationSettings notification_settings = 2;
+ optional AppNotificationSettings notification_settings = 2;
// This controls where on a page this application icon will appear.
optional string app_launch_ordinal = 3;
@@ -56,5 +56,16 @@ message AppSpecifics {
// This values only provide the order within the application pages, not within
// all of the panels in the NTP.
optional string page_ordinal = 4;
-}
+ // The possible launch types for an app.
+ // This enum should be kept in sync with extensions::LaunchType.
+ enum LaunchType {
+ PINNED = 0;
+ REGULAR = 1;
+ FULLSCREEN = 2;
+ WINDOW = 3;
+ }
+
+ // This describes how the extension should be launched.
+ optional LaunchType launch_type = 5;
+}
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | sync/protocol/proto_enum_conversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698