Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Side by Side Diff: sync/protocol/app_specifics.proto

Issue 93883004: Sync the launch type pref for apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unfix nit because it prevents testing of how invalid values are handled Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | sync/protocol/proto_enum_conversions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Sync protocol datatype extension for apps. 5 // Sync protocol datatype extension for apps.
6 6
7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change 7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
8 // any fields in this file. 8 // any fields in this file.
9 9
10 syntax = "proto2"; 10 syntax = "proto2";
(...skipping 29 matching lines...) Expand all
40 40
41 // Properties of app sync objects. 41 // Properties of app sync objects.
42 // 42 //
43 // For now, an app is just an extension. We keep the two data types 43 // For now, an app is just an extension. We keep the two data types
44 // separate for future-proofing purposes. 44 // separate for future-proofing purposes.
45 message AppSpecifics { 45 message AppSpecifics {
46 // Extension data. 46 // Extension data.
47 optional ExtensionSpecifics extension = 1; 47 optional ExtensionSpecifics extension = 1;
48 48
49 // Notification settings. 49 // Notification settings.
50 optional AppNotificationSettings notification_settings = 2; 50 optional AppNotificationSettings notification_settings = 2;
51 51
52 // This controls where on a page this application icon will appear. 52 // This controls where on a page this application icon will appear.
53 optional string app_launch_ordinal = 3; 53 optional string app_launch_ordinal = 3;
54 54
55 // This specifics which page the application icon will appear on in the NTP. 55 // This specifics which page the application icon will appear on in the NTP.
56 // This values only provide the order within the application pages, not within 56 // This values only provide the order within the application pages, not within
57 // all of the panels in the NTP. 57 // all of the panels in the NTP.
58 optional string page_ordinal = 4; 58 optional string page_ordinal = 4;
59
60 // The possible launch types for an app.
61 // This enum should be kept in sync with extensions::LaunchType.
62 enum LaunchType {
63 PINNED = 0;
64 REGULAR = 1;
65 FULLSCREEN = 2;
66 WINDOW = 3;
67 }
68
69 // This describes how the extension should be launched.
70 optional LaunchType launch_type = 5;
59 } 71 }
60
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | sync/protocol/proto_enum_conversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698