Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: sync/protocol/app_specifics.proto

Issue 93883004: Sync the launch type pref for apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better launch type validity checks Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/protocol/app_specifics.proto
diff --git a/sync/protocol/app_specifics.proto b/sync/protocol/app_specifics.proto
index a7f09ec1be197369b5170c402c699554e274acae..8c3f0ebb740d95ff889b0d71daafd18aaf9a5e90 100644
--- a/sync/protocol/app_specifics.proto
+++ b/sync/protocol/app_specifics.proto
@@ -47,7 +47,7 @@ message AppSpecifics {
optional ExtensionSpecifics extension = 1;
// Notification settings.
- optional AppNotificationSettings notification_settings = 2;
+ optional AppNotificationSettings notification_settings = 2;
// This controls where on a page this application icon will appear.
optional string app_launch_ordinal = 3;
@@ -56,5 +56,7 @@ message AppSpecifics {
// This values only provide the order within the application pages, not within
// all of the panels in the NTP.
optional string page_ordinal = 4;
-}
+ // This describes how the extension should be launched.
+ optional int32 launch_type = 5;
Nicolas Zea 2013/12/18 21:14:04 Make this an enum as well?
calamity 2013/12/19 06:27:52 Done.
+}

Powered by Google App Engine
This is Rietveld 408576698