Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/extension_constants.h

Issue 93883004: Sync the launch type pref for apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better launch type validity checks Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/launch_util.cc ('K') | « chrome/browser/ui/webui/ntp/app_launcher_handler.cc ('k') | sync/protocol/app_specifics.proto » ('j') | sync/protocol/app_specifics.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_constants.h
diff --git a/chrome/common/extensions/extension_constants.h b/chrome/common/extensions/extension_constants.h
index a13bc5ec6befe59e23f5b962a42df33060340f6d..f35c967fc026d2a60625a5967aaadefc69e4ca26 100644
--- a/chrome/common/extensions/extension_constants.h
+++ b/chrome/common/extensions/extension_constants.h
@@ -319,10 +319,13 @@ namespace extensions {
// Do not remove items or re-order this enum as it is used in preferences
// and histograms.
enum LaunchType {
- LAUNCH_TYPE_PINNED,
- LAUNCH_TYPE_REGULAR,
- LAUNCH_TYPE_FULLSCREEN,
- LAUNCH_TYPE_WINDOW,
+ LAUNCH_TYPE_INVALID = -1,
+ LAUNCH_TYPE_FIRST = 0,
+ LAUNCH_TYPE_PINNED = LAUNCH_TYPE_FIRST,
+ LAUNCH_TYPE_REGULAR = 1,
+ LAUNCH_TYPE_FULLSCREEN = 2,
+ LAUNCH_TYPE_WINDOW = 3,
+ NUM_LAUNCH_TYPES,
// Launch an app in the in the way a click on the NTP would,
// if no user pref were set. Update this constant to change
« chrome/browser/extensions/launch_util.cc ('K') | « chrome/browser/ui/webui/ntp/app_launcher_handler.cc ('k') | sync/protocol/app_specifics.proto » ('j') | sync/protocol/app_specifics.proto » ('J')

Powered by Google App Engine
This is Rietveld 408576698