[Telemetry] Add results filtering.

[Telemetry] Add results filtering.

BUG=439497
Committed: https://crrev.com/45400a6f1f2082d36501591a0c04fe42734142e7
Cr-Commit-Position: refs/heads/master@{#316941}

[nednguyen, 2015-02-18 16:45:19]

nednguyen@google.com changed reviewers:
+ nduca@chromium.org, sullivan@chromium.org

[nduca, 2015-02-18 20:13:44]

lgtm with nits , suggest eakuefner for additional coverage

https://codereview.chromium.org/938743002/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/page_test_results.py (right):

https://codereview.chromium.org/938743002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/page_test_results.py:26:
values_filter_callback=lambda v: True):
predicate is the word used typically for a callback that is a true/false check
kind of thing.

value_is_interesting_predicate?

https://codereview.chromium.org/938743002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/page_test_results.py:27: """
any rationale on why this is a construction time parameter vs a property that
you can set? Seems like it could be a property ... the only time we need a
construction time thing is if we absolutely require that it be immutable during
run... doesn't seem like any harm if you change it...

[nednguyen, 2015-02-18 20:30:34]

nednguyen@google.com changed reviewers:
+ eakuefner@chromium.org

[nednguyen, 2015-02-18 20:35:57]

https://codereview.chromium.org/938743002/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/page_test_results.py (right):

https://codereview.chromium.org/938743002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/page_test_results.py:27: """
On 2015/02/18 20:13:44, nduca wrote:
> any rationale on why this is a construction time parameter vs a property that
> you can set? Seems like it could be a property ... the only time we need a
> construction time thing is if we absolutely require that it be immutable
during
> run... doesn't seem like any harm if you change it...

I want only benchmark can set this and don't want to allow page_test to set
this. PageTest/UserStoryTest should produce all the metrics they can.

[sullivan, 2015-02-18 21:33:20]

lgtm

[nednguyen, 2015-02-18 21:55:14]

New patchsets have been uploaded after l-g-t-m from
nduca@chromium.org,sullivan@chromium.org

[nednguyen, 2015-02-18 21:55:33]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-02-18 21:56:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/938743002/20001

[commit-bot: I haz the power, 2015-02-18 23:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-18 23:07:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nednguyen, 2015-02-18 23:12:32]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-02-18 23:13:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/938743002/40001

[eakuefner, 2015-02-18 23:22:54]

lgtm

Name nit: why not ValueFilterPredicate? I agree with nduca that predicate is the
right word, but you used filter as a descriptor originally. I like that, since
this is analogous to a filter operation in functional programming.

[nednguyen, 2015-02-18 23:51:02]

On 2015/02/18 23:22:54, eakuefner wrote:
> lgtm
> 
> Name nit: why not ValueFilterPredicate? I agree with nduca that predicate is
the
> right word, but you used filter as a descriptor originally. I like that, since
> this is analogous to a filter operation in functional programming.

With ValueCanBeAddedPredicate, it's pretty clear what this does whereas
ValueFilterPredicate required more code reading.

[commit-bot: I haz the power, 2015-02-19 01:05:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-19 01:05:59]

Patchset 3 (id:??) landed as
https://crrev.com/45400a6f1f2082d36501591a0c04fe42734142e7
Cr-Commit-Position: refs/heads/master@{#316941}