Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 938743002: [Telemetry] Add results filtering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ready to land Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/page_test_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/page_test_results_unittest.py b/tools/telemetry/telemetry/results/page_test_results_unittest.py
index 0073536d74ebd590e6c7eede26e689e8f7870ebd..b8313dad6a01c9995aea423c90f46e52fc9719cd 100644
--- a/tools/telemetry/telemetry/results/page_test_results_unittest.py
+++ b/tools/telemetry/telemetry/results/page_test_results_unittest.py
@@ -45,6 +45,7 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
self.assertTrue(results.all_page_runs[0].failed)
self.assertTrue(results.all_page_runs[1].ok)
+
def testSkips(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self.pages[0])
@@ -84,6 +85,38 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
values = results.FindAllPageSpecificValuesNamed('a')
assert len(values) == 2
+ def testResultsFiltering(self):
+ def AcceptValueNamed_a(value):
+ return value.name == 'a'
+ results = page_test_results.PageTestResults(
+ value_can_be_added_predicate=AcceptValueNamed_a)
+ results.WillRunPage(self.pages[0])
+ results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
+ results.AddValue(scalar.ScalarValue(self.pages[0], 'b', 'seconds', 3))
+ results.DidRunPage(self.pages[0])
+
+ results.WillRunPage(self.pages[1])
+ results.AddValue(scalar.ScalarValue(self.pages[1], 'a', 'seconds', 3))
+ results.AddValue(scalar.ScalarValue(self.pages[1], 'd', 'seconds', 3))
+ results.DidRunPage(self.pages[1])
+
+ results.PrintSummary()
+
+ values = results.FindPageSpecificValuesForPage(self.pages[0], 'a')
+ self.assertEquals(1, len(values))
+ v = values[0]
+ self.assertEquals(v.name, 'a')
+ self.assertEquals(v.page, self.pages[0])
+
+ values = results.FindPageSpecificValuesForPage(self.pages[0], 'b')
+ self.assertEquals(0, len(values))
+
+ values = results.FindAllPageSpecificValuesNamed('a')
+ self.assertEquals(len(values), 2)
+
+ values = results.all_page_specific_values
+ self.assertEquals(len(values), 2)
+
def testUrlIsInvalidValue(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self.pages[0])
« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results.py ('k') | tools/telemetry/telemetry/results/results_options.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698