Source/bindings/scripts/v8_dictionary.py - Issue 938733003: IDL: Fix exception handling when converting V8 value to union/dictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_dictionary.py

Issue 938733003: IDL: Fix exception handling when converting V8 value to union/dictionary (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_dictionary.py

diff --git a/Source/bindings/scripts/v8_dictionary.py b/Source/bindings/scripts/v8_dictionary.py

index 3e8ee8cc192ee03ce4136ac0ec47504251279075..7a763c2f1978c9e280f5ff5b842812d24b0998f9 100644

--- a/Source/bindings/scripts/v8_dictionary.py

+++ b/Source/bindings/scripts/v8_dictionary.py

@@ -121,7 +121,8 @@ def member_context(dictionary, member):

'v8_default_value': v8_default_value,

'v8_value_to_local_cpp_value': unwrapped_idl_type.v8_value_to_local_cpp_value(

member.extended_attributes, member.name + 'Value',

- member.name, isolate='isolate', restricted_float=restricted_float),

+ member.name, isolate='isolate', restricted_float=restricted_float,

+ needs_exception_state_for_string=True, no_throw=True),

}

« no previous file with comments | « Source/bindings/core/v8/V8BindingMacros.h ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »