Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: Source/bindings/core/v8/V8BindingMacros.h

Issue 938733003: IDL: Fix exception handling when converting V8 value to union/dictionary (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_dictionary.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8BindingMacros.h
diff --git a/Source/bindings/core/v8/V8BindingMacros.h b/Source/bindings/core/v8/V8BindingMacros.h
index 320cff6709bc0214451db6363bb4e03dfc294f1f..42556c5cbec3e8e00c79676fbe4ec526d9665e67 100644
--- a/Source/bindings/core/v8/V8BindingMacros.h
+++ b/Source/bindings/core/v8/V8BindingMacros.h
@@ -99,11 +99,22 @@ namespace blink {
if (UNLIKELY(exceptionState.throwIfNeeded())) \
return;
+#define TONATIVE_VOID_EXCEPTIONSTATE_NOTHROW(type, var, value, exceptionState) \
+ type var; \
+ var = (value); \
+ if (UNLIKELY(exceptionState.hadException())) \
+ return;
+
#define TONATIVE_VOID_EXCEPTIONSTATE_ARGINTERNAL(value, exceptionState) \
(value); \
if (UNLIKELY(exceptionState.throwIfNeeded())) \
return;
+#define TONATIVE_VOID_EXCEPTIONSTATE_ARGINTERNAL_NOTHROW(value, exceptionState) \
+ (value); \
+ if (UNLIKELY(exceptionState.hadException())) \
+ return;
+
#define TONATIVE_DEFAULT_EXCEPTIONSTATE(type, var, value, exceptionState, retVal) \
type var = (value); \
if (UNLIKELY(exceptionState.throwIfNeeded())) \
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_dictionary.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698