Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: ipc/ipc_test_base.cc

Issue 938453002: Remove base::WaitForSingleProcess (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: check exit code Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_test_base.cc
diff --git a/ipc/ipc_test_base.cc b/ipc/ipc_test_base.cc
index 17fce0baace389c355d277ef58c82a91d3fa0b43..ca351e345c0aab32b3bd886f59dc6d49ab6da868 100644
--- a/ipc/ipc_test_base.cc
+++ b/ipc/ipc_test_base.cc
@@ -142,8 +142,9 @@ bool IPCTestBase::StartClient() {
bool IPCTestBase::WaitForClientShutdown() {
DCHECK(client_process_.IsValid());
- bool rv = base::WaitForSingleProcess(client_process_.Handle(),
- base::TimeDelta::FromSeconds(5));
+ int exit_code;
Tom Sepez 2015/02/18 23:49:53 do we want to set exit_code to some impossible val
rvargas (doing something else) 2015/02/19 02:01:04 I have no idea what an impossible (or reasonable)
+ bool rv = client_process_.WaitForExitWithTimeout(
+ base::TimeDelta::FromSeconds(5), &exit_code);
client_process_.Close();
return rv;
}
« no previous file with comments | « chrome/utility/importer/firefox_importer_unittest_utils_mac.cc ('k') | net/test/spawned_test_server/local_test_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698