Remove base::WaitForSingleProcess

ipc/ipc_test_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include "ipc/ipc_test_base.h"
 
 #include "base/command_line.h"
 #include "base/process/kill.h"
@@ skipping 124 matching lines @@
   DCHECK(!client_process_.IsValid());
   client_process_ = SpawnChild(GetTestMainName());
   return DidStartClient();
 }
 
 #endif
 
 bool IPCTestBase::WaitForClientShutdown() {
   DCHECK(client_process_.IsValid());
 
-  bool rv = base::WaitForSingleProcess(client_process_.Handle(),
-                                       base::TimeDelta::FromSeconds(5));
+  int exit_code;

[Tom Sepez, 2015/02/18 23:49:53]

do we want to set exit_code to some impossible value and then EXPECT that
WaitForExitWithTimeout set it to something reasonable?

[rvargas (doing something else), 2015/02/19 02:01:04]

I have no idea what an impossible (or reasonable) value would be.

I can EXPECT that to be 0 if you want me to, and see if the bots are happy with
that... I just don't see how this layer can predict what the exit code would be
or how a zero exit code (or anything) is implied by the contract of
WaitForClientShutdown()

Let me know what you want me to do.

+  bool rv = client_process_.WaitForExitWithTimeout(
+                base::TimeDelta::FromSeconds(5), &exit_code);
   client_process_.Close();
   return rv;
 }
 
 IPC::ChannelHandle IPCTestBase::GetTestChannelHandle() {
   return GetChannelName(test_client_name_);
 }
 
 scoped_refptr<base::TaskRunner> IPCTestBase::task_runner() {
   return message_loop_->message_loop_proxy();
 }
 
 scoped_ptr<IPC::ChannelFactory> IPCTestBase::CreateChannelFactory(
     const IPC::ChannelHandle& handle,
     base::TaskRunner* runner) {
   return IPC::ChannelFactory::Create(handle, IPC::Channel::MODE_SERVER);
 }