Remove base::WaitForSingleProcess

ipc/ipc_test_base.cc

Index: ipc/ipc_test_base.cc
diff --git a/ipc/ipc_test_base.cc b/ipc/ipc_test_base.cc
index 17fce0baace389c355d277ef58c82a91d3fa0b43..ca351e345c0aab32b3bd886f59dc6d49ab6da868 100644
--- a/ipc/ipc_test_base.cc
+++ b/ipc/ipc_test_base.cc
@@ -142,8 +142,9 @@ bool IPCTestBase::StartClient() {
 bool IPCTestBase::WaitForClientShutdown() {
   DCHECK(client_process_.IsValid());
 
-  bool rv = base::WaitForSingleProcess(client_process_.Handle(),
-                                       base::TimeDelta::FromSeconds(5));
+  int exit_code;
+  bool rv = client_process_.WaitForExitWithTimeout(
+                base::TimeDelta::FromSeconds(5), &exit_code);

[Lei Zhang, 2015/02/18 03:07:43]

nit: Indentation looks funny. Shouldn't it be 4 spaces from where "bool" starts?
Ditto in service_process_control_browsertest.cc.

[rvargas (doing something else), 2015/02/18 23:17:58]

Maybe? I actually prefer this (since it was taught to me on my readability
review) because (tldr):

SomethingLong(with_some_long_args,
              is_indented_here_and_not_under_thing

something = sequence_of_foo +
            some_more_bar

Which means that there are points of "natural" indentation. The four spaces rule
should not go beyond those points unless there is not enough space even after
moving to that extra line (so in fact should be "4 spaces from that point").

something = SomethingExtraLong(
                with_many_long_args) +
            SomethingElse()

is easier to parse (even if the whole thing has to be moved to the next line),
versus:

something =
    SomethingExtraLong(
    with_many_long_args) + <----
    SomethingElse()

"with_many_long_args" really needs more indentation, not just 4 from start, and
in one case it is just using the same principles while with the other
interpretation it just comes out of nowhere.

[Lei Zhang, 2015/02/18 23:48:31]

I haven't seen much code written this way though. See lines 81 / 90 for
instance. Maybe just clang-format it all and call it a day?

[rvargas (doing something else), 2015/02/19 02:01:04]

I cringe every time I see code like that :(. But I agree that it is a common
pattern in parts of the code. I have also seen clang-format destroy better
formatting in the name of easier-to-program rules, which also makes me sad.

clang-format seems inconsistent (buggy?) to me in that it generates:
  bool rv = kjhkd +
            client_process_.WaitForExitWithTimeout(
                base::TimeDelta::FromSeconds(5), &exit_code);

but without the first term it insist in sending the arguments beyond rv. I filed
bug 459823 about it.

I would be happy with defaulting to clang-format if the style guide were
replaced with "use whatever the tool does".

For now there's not much point in arguing about it.

   client_process_.Close();
   return rv;
 }