chrome/utility/importer/firefox_importer_unittest_utils_mac.cc - Issue 938453002: Remove base::WaitForSingleProcess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/firefox_importer_unittest_utils_mac.cc

Issue 938453002: Remove base::WaitForSingleProcess (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/utility/importer/firefox_importer_unittest_utils_mac.cc

diff --git a/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc b/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc

index 7000fc4a735c165d7834c95275938f3cd8e3ad5d..28568499d91430e9bef273fa8994adba668965d2 100644

--- a/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc

+++ b/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc

@@ -151,9 +151,9 @@ FFUnitTestDecryptorProxy::~FFUnitTestDecryptorProxy() {

channel_->Close();

if (child_process_.IsValid()) {

- base::WaitForSingleProcess(child_process_.Handle(),

- base::TimeDelta::FromSeconds(5));

- child_process_.Close();

+ int exit_code;

+ child_process_.WaitForExitWithTimeout(base::TimeDelta::FromSeconds(5),

+ &exit_code);

}