chrome/browser/service_process/service_process_control_browsertest.cc - Issue 938453002: Remove base::WaitForSingleProcess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/service_process/service_process_control_browsertest.cc

Issue 938453002: Remove base::WaitForSingleProcess (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/process/kill_win.cc ('K') | « chrome/browser/process_singleton_browsertest.cc ('k') | chrome/utility/importer/firefox_importer_unittest_utils_mac.cc » ('j') | ipc/ipc_test_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/service_process/service_process_control_browsertest.cc

diff --git a/chrome/browser/service_process/service_process_control_browsertest.cc b/chrome/browser/service_process/service_process_control_browsertest.cc

index a159f384f05a446b6c47eb820c7f1b4b66254839..ac16fc851175968bca1334607447a169df424f14 100644

--- a/chrome/browser/service_process/service_process_control_browsertest.cc

+++ b/chrome/browser/service_process/service_process_control_browsertest.cc

@@ -80,9 +80,9 @@ class ServiceProcessControlBrowserTest

ForceServiceProcessShutdown("", 0);

#endif // OS_MACOSX

if (service_process_.IsValid()) {

- EXPECT_TRUE(base::WaitForSingleProcess(

- service_process_.Handle(),

- TestTimeouts::action_max_timeout()));

+ int exit_code;

+ EXPECT_TRUE(service_process_.WaitForExitWithTimeout(

+ TestTimeouts::action_max_timeout(), &exit_code));

service_process_.Close();

}

« base/process/kill_win.cc ('K') | « chrome/browser/process_singleton_browsertest.cc ('k') | chrome/utility/importer/firefox_importer_unittest_utils_mac.cc » ('j') | ipc/ipc_test_base.cc » ('J')