Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: src/hydrogen.cc

Issue 938443002: [es6] implement spread calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add some perf tests (this stuff is slow ._.) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 35761f7436da2b7aec4a3f323808b0a381add2d7..6819041c92b4aaef82c1bcd3dc32b3d74498fb7f 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -11028,6 +11028,9 @@ void HOptimizedGraphBuilder::HandleLiteralCompareNil(CompareOperation* expr,
}
+void HOptimizedGraphBuilder::VisitSpread(Spread* expr) { UNREACHABLE(); }
Dmitry Lomov (no reviews) 2015/04/02 07:54:20 One thing I am missing: why this is never hit?
caitp (gmail) 2015/04/02 13:03:51 the Spread nodes are removed from the graph, they'
+
+
HInstruction* HOptimizedGraphBuilder::BuildThisFunction() {
// If we share optimized code between different closures, the
// this-function is not a constant, except inside an inlined body.
« src/harmony-spread.js ('K') | « src/harmony-spread.js ('k') | src/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698