Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/hydrogen.cc

Issue 938443002: [es6] implement spread calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add some perf tests (this stuff is slow ._.) Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/hydrogen.h" 5 #include "src/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 11010 matching lines...) Expand 10 before | Expand all | Expand 10 after
11021 DCHECK_EQ(Token::EQ, expr->op()); 11021 DCHECK_EQ(Token::EQ, expr->op());
11022 Type* type = expr->combined_type()->Is(Type::None()) 11022 Type* type = expr->combined_type()->Is(Type::None())
11023 ? Type::Any(zone()) : expr->combined_type(); 11023 ? Type::Any(zone()) : expr->combined_type();
11024 HIfContinuation continuation; 11024 HIfContinuation continuation;
11025 BuildCompareNil(value, type, &continuation); 11025 BuildCompareNil(value, type, &continuation);
11026 return ast_context()->ReturnContinuation(&continuation, expr->id()); 11026 return ast_context()->ReturnContinuation(&continuation, expr->id());
11027 } 11027 }
11028 } 11028 }
11029 11029
11030 11030
11031 void HOptimizedGraphBuilder::VisitSpread(Spread* expr) { UNREACHABLE(); }
Dmitry Lomov (no reviews) 2015/04/02 07:54:20 One thing I am missing: why this is never hit?
caitp (gmail) 2015/04/02 13:03:51 the Spread nodes are removed from the graph, they'
11032
11033
11031 HInstruction* HOptimizedGraphBuilder::BuildThisFunction() { 11034 HInstruction* HOptimizedGraphBuilder::BuildThisFunction() {
11032 // If we share optimized code between different closures, the 11035 // If we share optimized code between different closures, the
11033 // this-function is not a constant, except inside an inlined body. 11036 // this-function is not a constant, except inside an inlined body.
11034 if (function_state()->outer() != NULL) { 11037 if (function_state()->outer() != NULL) {
11035 return New<HConstant>( 11038 return New<HConstant>(
11036 function_state()->compilation_info()->closure()); 11039 function_state()->compilation_info()->closure());
11037 } else { 11040 } else {
11038 return New<HThisFunction>(); 11041 return New<HThisFunction>();
11039 } 11042 }
11040 } 11043 }
(...skipping 2359 matching lines...) Expand 10 before | Expand all | Expand 10 after
13400 if (ShouldProduceTraceOutput()) { 13403 if (ShouldProduceTraceOutput()) {
13401 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13404 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13402 } 13405 }
13403 13406
13404 #ifdef DEBUG 13407 #ifdef DEBUG
13405 graph_->Verify(false); // No full verify. 13408 graph_->Verify(false); // No full verify.
13406 #endif 13409 #endif
13407 } 13410 }
13408 13411
13409 } } // namespace v8::internal 13412 } } // namespace v8::internal
OLDNEW
« src/harmony-spread.js ('K') | « src/harmony-spread.js ('k') | src/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698