Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 9382044: mac: Support ARCHS with zero or one element in the make and ninja generators. (Closed)

Created:
7 years, 10 months ago by ukai
Modified:
7 years, 9 months ago
Reviewers:
Mark Mentovai, Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

mac: Support ARCHS with zero or one element in the make and ninja generators. General ARCHS support (fat binaries) are still unsupported. Review URL: http://codereview.chromium.org/9382044 Landed in gyp r1198.

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -7 lines) Patch
M pylib/gyp/xcode_emulation.py View 1 2 3 chunks +12 lines, -7 lines 0 comments Download
A test/mac/archs/my_file.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A test/mac/archs/my_main_file.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A test/mac/archs/test-archs-x86_64.gyp View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A test/mac/archs/test-no-archs.gyp View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A test/mac/gyptest-archs.py View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ukai
7 years, 10 months ago (2012-02-13 05:56:49 UTC) #1
Nico
Thanks for working on this! It looks like dump_syms (in breakpad/breakpad.gyp) doesn't depend on anything, ...
7 years, 10 months ago (2012-02-13 06:09:07 UTC) #2
ukai
On 2012/02/13 06:09:07, Nico wrote: > Thanks for working on this! It looks like dump_syms ...
7 years, 10 months ago (2012-02-13 07:02:12 UTC) #3
Mark Mentovai
Xcode requires ARCHS (although its value may be implicit) and always invokes the compiler with ...
7 years, 10 months ago (2012-02-13 17:07:07 UTC) #4
Nico
What does xcode do for { 'targets': [ { 'target_name': 'lib', 'type': 'static_library', 'sources': 'my_file.cc', ...
7 years, 9 months ago (2012-02-14 01:16:43 UTC) #5
ukai
On 2012/02/14 01:16:43, Nico wrote: > What does xcode do for > > { > ...
7 years, 9 months ago (2012-02-14 05:17:23 UTC) #6
ukai
http://codereview.chromium.org/9382044/diff/4001/pylib/gyp/xcode_emulation.py File pylib/gyp/xcode_emulation.py (right): http://codereview.chromium.org/9382044/diff/4001/pylib/gyp/xcode_emulation.py#newcode296 pylib/gyp/xcode_emulation.py:296: cflags.append('-arch i386') On 2012/02/14 01:16:43, Nico wrote: > nit: ...
7 years, 9 months ago (2012-02-14 06:09:33 UTC) #7
Nico
Lgtm. Looks great, thanks! Nit: the CC files need license headers. http://codereview.chromium.org/9382044/diff/9001/test/mac/gyptest-archs.py File test/mac/gyptest-archs.py (right): ...
7 years, 9 months ago (2012-02-14 06:25:46 UTC) #8
ukai
http://codereview.chromium.org/9382044/diff/9001/test/mac/gyptest-archs.py File test/mac/gyptest-archs.py (right): http://codereview.chromium.org/9382044/diff/9001/test/mac/gyptest-archs.py#newcode23 test/mac/gyptest-archs.py:23: test.fail_test() On 2012/02/14 06:25:46, Nico wrote: > Is test ...
7 years, 9 months ago (2012-02-14 06:38:39 UTC) #9
Nico
I'll land this tomorrow morning!
7 years, 9 months ago (2012-02-14 06:43:24 UTC) #10
Nico
7 years, 9 months ago (2012-02-14 16:35:35 UTC) #11
On 2012/02/14 06:43:24, Nico wrote:
> I'll land this tomorrow morning!

r1198

Powered by Google App Engine
This is Rietveld 408576698