Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 9382033: objects: fix template-related linker error (Closed)

Created:
7 years, 6 months ago by indutny
Modified:
7 years, 6 months ago
Reviewers:
Erik Corry, danno
CC:
v8-dev
Base URL:
gh:v8/v8@master
Visibility:
Public.

Description

objects: fix template-related linker error R=erik.corry@gmail.com BUG=v8:1936 TEST= Committed: https://code.google.com/p/v8/source/detail?r=10691

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
indutny
7 years, 6 months ago (2012-02-11 12:41:40 UTC) #1
danno
LGTM. Landing.
7 years, 6 months ago (2012-02-14 09:41:34 UTC) #2
indutny
On 2012/02/14 09:41:34, danno wrote: > LGTM. Landing. Can we backport it to 3.6.x?
7 years, 6 months ago (2012-02-14 09:53:29 UTC) #3
danno
On 2012/02/14 09:53:29, indutny wrote: > On 2012/02/14 09:41:34, danno wrote: > > LGTM. Landing. ...
7 years, 6 months ago (2012-02-14 10:58:12 UTC) #4
danno
Is this the only symbol that needs to be defined for the backport? Erik added ...
7 years, 6 months ago (2012-02-14 12:06:15 UTC) #5
indutny
The error I reported in issue was noticed on node.js v0.6.x which uses 3.6. Sorry, ...
7 years, 6 months ago (2012-02-14 12:08:24 UTC) #6
danno
Unfortunately, versions previous to 3.8 do not have the seeded/unseeded number dictionaries at all, so ...
7 years, 6 months ago (2012-02-14 12:19:16 UTC) #7
indutny
7 years, 6 months ago (2012-02-14 12:19:46 UTC) #8
Ok, Thank you anyway!

Powered by Google App Engine
This is Rietveld 408576698