Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 938193004: Remove dead position:relative code. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
esprehn
CC:
abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove dead position:relative code. There are some cases in this patch where it's not obvious that the code only applies to position:relative, but the code asserts that it does. In those cases, I trusted the asserts and deleted the code. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6496a49b1729ceb0b4cc42bfcbb823ee23da7094

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -219 lines) Patch
M sky/engine/core/rendering/LayoutState.cpp View 1 chunk +0 lines, -8 lines 2 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 7 chunks +12 lines, -99 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.h View 3 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 3 chunks +0 lines, -57 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/line/BreakingContextInlineHeaders.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
esprehn
https://codereview.chromium.org/938193004/diff/1/sky/engine/core/rendering/LayoutState.cpp File sky/engine/core/rendering/LayoutState.cpp (left): https://codereview.chromium.org/938193004/diff/1/sky/engine/core/rendering/LayoutState.cpp#oldcode56 sky/engine/core/rendering/LayoutState.cpp:56: m_layoutOffset += toRenderInline(container)->offsetForInFlowPositionedInline(renderer); Isn't this position: absolute inside an ...
5 years, 10 months ago (2015-02-20 05:55:53 UTC) #2
ojan
https://codereview.chromium.org/938193004/diff/1/sky/engine/core/rendering/LayoutState.cpp File sky/engine/core/rendering/LayoutState.cpp (left): https://codereview.chromium.org/938193004/diff/1/sky/engine/core/rendering/LayoutState.cpp#oldcode56 sky/engine/core/rendering/LayoutState.cpp:56: m_layoutOffset += toRenderInline(container)->offsetForInFlowPositionedInline(renderer); On 2015/02/20 05:55:53, esprehn wrote: > ...
5 years, 10 months ago (2015-02-20 05:57:21 UTC) #3
esprehn
lgtm, but I think that one part might be needed.
5 years, 10 months ago (2015-02-20 06:02:32 UTC) #4
ojan
On 2015/02/20 at 06:02:32, esprehn wrote: > lgtm, but I think that one part might ...
5 years, 10 months ago (2015-02-20 19:36:20 UTC) #5
esprehn
On 2015/02/20 at 19:36:20, ojan wrote: > On 2015/02/20 at 06:02:32, esprehn wrote: > > ...
5 years, 10 months ago (2015-02-20 19:37:20 UTC) #6
ojan
5 years, 10 months ago (2015-02-20 19:37:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6496a49b1729ceb0b4cc42bfcbb823ee23da7094 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698