Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: sky/engine/core/rendering/RenderObject.h

Issue 938193004: Remove dead position:relative code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 bool isAnonymous() const { return m_bitfields.isAnonymous(); } 301 bool isAnonymous() const { return m_bitfields.isAnonymous(); }
302 bool isAnonymousBlock() const 302 bool isAnonymousBlock() const
303 { 303 {
304 // This function is kept in sync with anonymous block creation condition s in 304 // This function is kept in sync with anonymous block creation condition s in
305 // RenderBlock::createAnonymousBlock(). This includes creating an anonym ous 305 // RenderBlock::createAnonymousBlock(). This includes creating an anonym ous
306 // RenderBlock having a BLOCK or BOX display. See https://bugs.webkit.or g/show_bug.cgi?id=56709. 306 // RenderBlock having a BLOCK or BOX display. See https://bugs.webkit.or g/show_bug.cgi?id=56709.
307 return isAnonymous() && style()->display() == PARAGRAPH; 307 return isAnonymous() && style()->display() == PARAGRAPH;
308 } 308 }
309 309
310 bool isOutOfFlowPositioned() const { return m_bitfields.isOutOfFlowPositione d(); } // absolute or fixed positioning 310 bool isOutOfFlowPositioned() const { return m_bitfields.isOutOfFlowPositione d(); } // absolute or fixed positioning
311 bool isRelPositioned() const { return m_bitfields.isRelPositioned(); } // re lative positioning
312 bool isPositioned() const { return m_bitfields.isPositioned(); } 311 bool isPositioned() const { return m_bitfields.isPositioned(); }
313 312
314 bool isText() const { return m_bitfields.isText(); } 313 bool isText() const { return m_bitfields.isText(); }
315 bool isBox() const { return m_bitfields.isBox(); } 314 bool isBox() const { return m_bitfields.isBox(); }
316 bool isInline() const { return m_bitfields.isInline(); } // inline object 315 bool isInline() const { return m_bitfields.isInline(); } // inline object
317 bool isDragging() const { return m_bitfields.isDragging(); } 316 bool isDragging() const { return m_bitfields.isDragging(); }
318 bool isReplaced() const { return m_bitfields.isReplaced(); } // a "replaced" element (see CSS) 317 bool isReplaced() const { return m_bitfields.isReplaced(); } // a "replaced" element (see CSS)
319 318
320 bool hasLayer() const { return m_bitfields.hasLayer(); } 319 bool hasLayer() const { return m_bitfields.hasLayer(); }
321 320
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
773 772
774 // from RenderInline 773 // from RenderInline
775 ADD_BOOLEAN_BITFIELD(alwaysCreateLineBoxesForRenderInline, AlwaysCreateL ineBoxesForRenderInline); 774 ADD_BOOLEAN_BITFIELD(alwaysCreateLineBoxesForRenderInline, AlwaysCreateL ineBoxesForRenderInline);
776 775
777 private: 776 private:
778 unsigned m_positionedState : 1; // PositionedState 777 unsigned m_positionedState : 1; // PositionedState
779 unsigned m_selectionState : 3; // SelectionState 778 unsigned m_selectionState : 3; // SelectionState
780 779
781 public: 780 public:
782 bool isOutOfFlowPositioned() const { return m_positionedState == IsOutOf FlowPositioned; } 781 bool isOutOfFlowPositioned() const { return m_positionedState == IsOutOf FlowPositioned; }
783 // FIXME(sky): Remove
784 bool isRelPositioned() const { return false; }
785 bool isPositioned() const { return m_positionedState != IsStaticallyPosi tioned; } 782 bool isPositioned() const { return m_positionedState != IsStaticallyPosi tioned; }
786 783
787 void setPositionedState(int positionState) 784 void setPositionedState(int positionState)
788 { 785 {
789 m_positionedState = static_cast<PositionedState>(positionState); 786 m_positionedState = static_cast<PositionedState>(positionState);
790 } 787 }
791 void clearPositionedState() { m_positionedState = StaticPosition; } 788 void clearPositionedState() { m_positionedState = StaticPosition; }
792 789
793 ALWAYS_INLINE SelectionState selectionState() const { return static_cast <SelectionState>(m_selectionState); } 790 ALWAYS_INLINE SelectionState selectionState() const { return static_cast <SelectionState>(m_selectionState); }
794 ALWAYS_INLINE void setSelectionState(SelectionState selectionState) { m_ selectionState = selectionState; } 791 ALWAYS_INLINE void setSelectionState(SelectionState selectionState) { m_ selectionState = selectionState; }
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
901 void showTree(const blink::RenderObject*); 898 void showTree(const blink::RenderObject*);
902 void showLineTree(const blink::RenderObject*); 899 void showLineTree(const blink::RenderObject*);
903 void showRenderTree(const blink::RenderObject* object1); 900 void showRenderTree(const blink::RenderObject* object1);
904 // We don't make object2 an optional parameter so that showRenderTree 901 // We don't make object2 an optional parameter so that showRenderTree
905 // can be called from gdb easily. 902 // can be called from gdb easily.
906 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2); 903 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2);
907 904
908 #endif 905 #endif
909 906
910 #endif // SKY_ENGINE_CORE_RENDERING_RENDEROBJECT_H_ 907 #endif // SKY_ENGINE_CORE_RENDERING_RENDEROBJECT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698