Issue 938073002: Clarify comment on FrameTree::AddFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 938073002: Clarify comment on FrameTree::AddFrame. (Closed)

Created:
5 years, 10 months ago by Charlie Reis

Modified:
5 years, 10 months ago

Reviewers:
alexmos

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Clarify comment on FrameTree::AddFrame. This behavior was updated in https://crrev.com/299939, but the comment didn't explain why the method might return null. BUG=none TEST=No behavior change. Committed: https://crrev.com/abf355c2d30860cc08ec8977815a164c44ec687a Cr-Commit-Position: refs/heads/master@{#317084}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	content/browser/frame_host/frame_tree.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	content/browser/frame_host/frame_tree.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938073002/1

5 years, 10 months ago (2015-02-19 17:57:59 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 18:49:50 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/abf355c2d30860cc08ec8977815a164c44ec687a
Cr-Commit-Position: refs/heads/master@{#317084}