content/browser/frame_host/frame_tree.h - Issue 938073002: Clarify comment on FrameTree::AddFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/frame_tree.h

Issue 938073002: Clarify comment on FrameTree::AddFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/frame_tree.h

diff --git a/content/browser/frame_host/frame_tree.h b/content/browser/frame_host/frame_tree.h

index 5f0c7aad333650f8fe2549f45346bbc710d751f1..df236574e30aeaeffe8dfa4108f08d7d1e593655 100644

--- a/content/browser/frame_host/frame_tree.h

+++ b/content/browser/frame_host/frame_tree.h

@@ -70,6 +70,10 @@ class CONTENT_EXPORT FrameTree {

void ForEach(const base::Callback<bool(FrameTreeNode*)>& on_node) const;

// Frame tree manipulation routines.

+ // |process_id| is required to disambiguate |new_routing_id|, and it must

+ // match the process of the |parent| node. Otherwise this method returns

+ // nullptr. Passing MSG_ROUTING_NONE for |new_routing_id| will allocate a new

+ // routing ID for the new frame.

RenderFrameHostImpl* AddFrame(FrameTreeNode* parent,

int process_id,

int new_routing_id,

« no previous file with comments | « no previous file | content/browser/frame_host/frame_tree.cc » ('j') | no next file with comments »