Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 93803004: Fix build output directories in GN. (Closed)

Created:
6 years, 11 months ago by brettw
Modified:
6 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Fix build output directories in GN. This puts the temporary build directories for the GYP builds at the same level as the main build output directory. This fixes problems where the build script converts paths to the build directory, and these get written to the GYP file. If the build directory is different relative to the source root than the GN build directory, the paths will be messed up. Fixes some Android goma issues for compat with the GYP build. TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242775

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -21 lines) Patch
M build/toolchain/android/BUILD.gn View 2 chunks +5 lines, -3 lines 0 comments Download
M build/toolchain/goma.gni View 1 3 chunks +9 lines, -12 lines 0 comments Download
M tools/gn/command_gyp.cc View 4 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
brettw
6 years, 11 months ago (2014-01-02 17:55:56 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 manually as r242775 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698