Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: build/toolchain/android/BUILD.gn

Issue 93803004: Fix build output directories in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/goma.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/android/BUILD.gn
diff --git a/build/toolchain/android/BUILD.gn b/build/toolchain/android/BUILD.gn
index c277263db1c7752ec640939b2c4f95c57f9ef87f..30614b088e6e67e734663173c2f529057f945369 100644
--- a/build/toolchain/android/BUILD.gn
+++ b/build/toolchain/android/BUILD.gn
@@ -9,8 +9,6 @@ import("../gcc_toolchain.gni")
# Get the location of the Android tools in our tree.
android_ndk_root =
rebase_path("//third_party/android_tools/ndk", ".", "")
-android_sdk_root =
- rebase_path("//third_party/android_tools/sdk", ".", "")
# Get the Android version of the name of the build host's architecture.
if (build_cpu_arch == "x64") {
@@ -39,8 +37,12 @@ if (is_gyp) {
assert(false, "Need Android toolchain support for your platform.")
}
+ # The extra slash before "toolchains" is because GYP generates this and we
+ # have to match the make_global_settings character-for-character,
+ # TODO(brettw) remove extra slash before toolchains when GYP compat is no
+ # longer necessary.
android_toolchain =
- "$android_ndk_root/toolchains/$android_toolchain_arch/prebuilt/$build_os-$android_host_arch/bin"
+ "$android_ndk_root//toolchains/$android_toolchain_arch/prebuilt/$build_os-$android_host_arch/bin"
# This script will find the compilers for the given Android toolchain
# directory.
« no previous file with comments | « no previous file | build/toolchain/goma.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698