Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 938003003: Add a new enable_nonblocking_io field trial param for QUIC (Closed)

Created:
5 years, 10 months ago by Ryan Hamilton
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Alpha Left Google
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new enable_nonblocking_io field trial param for QUIC which enables the new non-blocking IO support on windows. BUG=442392 Committed: https://crrev.com/83e8c1477cf5d41928b8c9035f0c4812828752f4 Cr-Commit-Position: refs/heads/master@{#318555}

Patch Set 1 #

Patch Set 2 : fix cast #

Patch Set 3 : more #

Patch Set 4 : pointer #

Patch Set 5 : working #

Total comments: 4

Patch Set 6 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M chrome/browser/io_thread.h View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 4 5 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 1 2 3 4 5 2 chunks +10 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_session.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 3 4 5 4 chunks +10 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Ryan Hamilton
5 years, 9 months ago (2015-02-27 22:49:22 UTC) #3
ramant (doing other things)
lgtm https://codereview.chromium.org/938003003/diff/100001/chrome/browser/io_thread.h File chrome/browser/io_thread.h (right): https://codereview.chromium.org/938003003/diff/100001/chrome/browser/io_thread.h#newcode193 chrome/browser/io_thread.h:193: Optional<bool> quic_enable_nonblocking_io; nit: consider "quic_enable_nonblocking_io" -> "quic_enable_non_blocking_io" to ...
5 years, 9 months ago (2015-02-27 23:03:29 UTC) #4
Ryan Hamilton
Good point! THanks! https://codereview.chromium.org/938003003/diff/100001/chrome/browser/io_thread.h File chrome/browser/io_thread.h (right): https://codereview.chromium.org/938003003/diff/100001/chrome/browser/io_thread.h#newcode193 chrome/browser/io_thread.h:193: Optional<bool> quic_enable_nonblocking_io; On 2015/02/27 23:03:29, ramant ...
5 years, 9 months ago (2015-02-27 23:07:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938003003/120001
5 years, 9 months ago (2015-02-27 23:08:18 UTC) #8
ramant (doing other things)
lgtm Still LGTM. Thanks for the change.
5 years, 9 months ago (2015-02-27 23:10:05 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 9 months ago (2015-02-28 00:07:53 UTC) #10
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/83e8c1477cf5d41928b8c9035f0c4812828752f4 Cr-Commit-Position: refs/heads/master@{#318555}
5 years, 9 months ago (2015-02-28 00:08:48 UTC) #11
qyearsley
A revert of this CL (patchset #6 id:120001) has been created in https://codereview.chromium.org/970513004/ by qyearsley@chromium.org. ...
5 years, 9 months ago (2015-02-28 06:11:44 UTC) #12
qyearsley
5 years, 9 months ago (2015-02-28 07:00:25 UTC) #13
Message was sent while issue was closed. 
On 2015/02/28 06:11:44, qyearsley wrote:
> A revert of this CL (patchset #6 id:120001) has been created in
> https://codereview.chromium.org/970513004/ by mailto:qyearsley@chromium.org.
> 
> The reason for reverting is: Speculative revert to see whether this affects
some
> tests that involve loading fonts in gfx_unittests (see failures at
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29....

Revert didn't work, re-landing: https://codereview.chromium.org/968573002/

Powered by Google App Engine
This is Rietveld 408576698