Add a new enable_nonblocking_io field trial param for QUIC

chrome/browser/io_thread.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_IO_THREAD_H_
 #define CHROME_BROWSER_IO_THREAD_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 172 matching lines @@
 
     Optional<bool> enable_quic;
     Optional<bool> enable_quic_for_proxies;
     Optional<bool> enable_quic_port_selection;
     Optional<bool> quic_always_require_handshake_confirmation;
     Optional<bool> quic_disable_connection_pooling;
     Optional<int> quic_load_server_info_timeout_ms;
     Optional<float> quic_load_server_info_timeout_srtt_multiplier;
     Optional<bool> quic_enable_truncated_connection_ids;
     Optional<bool> quic_enable_connection_racing;
+    Optional<bool> quic_enable_nonblocking_io;

[ramant (doing other things), 2015/02/27 23:03:29]

nit: consider "quic_enable_nonblocking_io" -> "quic_enable_non_blocking_io" to
be consistent with other code. It is your call.

https://code.google.com/p/chromium/codesearch#chromium/src/net/socket/tcp_soc...

[Ryan Hamilton, 2015/02/27 23:07:26]

Done.

     Optional<bool> quic_disable_disk_cache;
     Optional<size_t> quic_max_packet_length;
     net::QuicTagVector quic_connection_options;
     Optional<std::string> quic_user_agent_id;
     Optional<net::QuicVersionVector> quic_supported_versions;
     Optional<net::HostPortPair> origin_to_force_quic_on;
     bool enable_user_alternate_protocol_ports;
     // NetErrorTabHelper uses |dns_probe_service| to send DNS probes when a
     // main frame load fails with a DNS error in order to provide more useful
     // information to the renderer so it can show a more specific error page.
@@ skipping 174 matching lines @@
       const VariationParameters& quic_trial_params);
 
   // Returns true if QUIC's TruncatedConnectionIds should be enabled.
   static bool ShouldQuicEnableTruncatedConnectionIds(
       const VariationParameters& quic_trial_params);
 
   // Returns true if QUIC's connection racing should be enabled.
   static bool ShouldQuicEnableConnectionRacing(
       const VariationParameters& quic_trial_params);
 
+  // Returns true if QUIC's should use non-blocking IO.
+  static bool ShouldQuicEnableNonblockingIO(

[ramant (doing other things), 2015/02/27 23:03:29]

nit: "ShouldQuicEnableNonblockingIO" -> "ShouldQuicEnableNonBlockingIO" to
be consistent with other code. It is your call.

https://code.google.com/p/chromium/codesearch#chromium/src/net/udp/udp_socket...

[Ryan Hamilton, 2015/02/27 23:07:26]

Done.

+      const VariationParameters& quic_trial_params);
+
   // Returns true if QUIC shouldn't load QUIC server information from the disk
   // cache.
   static bool ShouldQuicDisableDiskCache(
       const VariationParameters& quic_trial_params);
 
   // Returns the maximum length for QUIC packets, based on any flags in
   // |command_line| or the field trial.  Returns 0 if there is an error
   // parsing any of the options, or if the default value should be used.
   static size_t GetQuicMaxPacketLength(
       const base::CommandLine& command_line,
@@ skipping 76 matching lines @@
   bool is_spdy_disabled_by_policy_;
 
   const base::TimeTicks creation_time_;
 
   base::WeakPtrFactory<IOThread> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(IOThread);
 };
 
 #endif  // CHROME_BROWSER_IO_THREAD_H_