Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 937843004: Disable bookmark apps on non-ChromeOS platforms. (Closed)

Created:
5 years, 10 months ago by tapted
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable bookmark apps on non-ChromeOS platforms. The world isn't quite ready for them.... BUG=459504 TBR=benwells@chromium.org,thestig@chromium.org Original patch from benwells; reviewed in http://crrev.com/938603002 Committed: https://crrev.com/bf201644b9a46832a8790ccefae6c5e2aaae2891 Cr-Commit-Position: refs/heads/master@{#317013}

Patch Set 1 #

Patch Set 2 : Baseline patch from crrev/938603002 #

Patch Set 3 : Keep flag in some tests to keep expectations on mac happy #

Patch Set 4 : More strict expectations #

Patch Set 5 : wow - how did that compile anywhere #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -14 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm View 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/management/management_apitest.cc View 1 2 3 4 2 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_util.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm View 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/web_apps.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/management/test/launchType.js View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
jack, ptal
5 years, 10 months ago (2015-02-19 05:11:07 UTC) #2
jackhou1
lgtm
5 years, 10 months ago (2015-02-19 05:44:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937843004/80001
5 years, 10 months ago (2015-02-19 07:54:57 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-19 08:45:34 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 08:47:19 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/bf201644b9a46832a8790ccefae6c5e2aaae2891
Cr-Commit-Position: refs/heads/master@{#317013}

Powered by Google App Engine
This is Rietveld 408576698