Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7999)

Unified Diff: chrome/test/data/extensions/api_test/management/test/launchType.js

Issue 937843004: Disable bookmark apps on non-ChromeOS platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wow - how did that compile anywhere Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/web_apps.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/management/test/launchType.js
diff --git a/chrome/test/data/extensions/api_test/management/test/launchType.js b/chrome/test/data/extensions/api_test/management/test/launchType.js
index b2d40f3ce6a13c06556fe24596f3fd4d637b9e8c..db35e6c7003fa50b49aa03a0b19fd670fda43466 100644
--- a/chrome/test/data/extensions/api_test/management/test/launchType.js
+++ b/chrome/test/data/extensions/api_test/management/test/launchType.js
@@ -32,6 +32,11 @@ function getAvailableLaunchTypes(app) {
types.push("OPEN_AS_REGULAR_TAB");
types.push("OPEN_AS_WINDOW");
+ if (navigator.userAgent.indexOf("CrOS") == -1) {
+ types.push("OPEN_AS_PINNED_TAB");
+ types.push("OPEN_FULL_SCREEN");
+ }
+
return types;
}
@@ -59,6 +64,13 @@ function testSetAllLaunchTypes(app) {
} else {
testSetLaunchType(app.id, type, null, function() {
chrome.management.get(app.id, function(item) {
+ if (navigator.userAgent.indexOf("Mac") != -1) {
+ // In the current configuration, with the new bookmark app flow
+ // disabled, hosted apps set to open in a window on Mac will open
+ // instead in a tab.
+ if (item.type != 'packaged_app' && type == 'OPEN_AS_WINDOW')
+ type = 'OPEN_AS_REGULAR_TAB';
+ }
assertEq(type, item.launchType);
setNextLaunchType();
});
« no previous file with comments | « chrome/renderer/web_apps.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698