Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 93783003: Revert 237638 "Build liblouis_nacl using gyp." (Closed)

Created:
7 years ago by ckocagil
Modified:
7 years ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 237638 "Build liblouis_nacl using gyp." > Build liblouis_nacl using gyp. > > This cl ports the nacl wrapper to the chromium build system and adds local modifications from Chromevox to liblouis. The native library and braille tables are copied to the location in the resources output directory where chromevox can pick them up. > > BUG=316353 > > Review URL: https://codereview.chromium.org/67283007 TBR=plundblad@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7587 lines) Patch
M trunk/src/build/gyp_chromium View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser_tests.isolate View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 1 chunk +1 line, -11 lines 0 comments Download
D trunk/src/chrome/test/data/chromeos/liblouis_nacl/manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D trunk/src/chrome/test/data/chromeos/liblouis_nacl/test.js View 1 chunk +0 lines, -85 lines 0 comments Download
M trunk/src/third_party/liblouis/README.chromium View 1 chunk +1 line, -10 lines 0 comments Download
D trunk/src/third_party/liblouis/liblouis_list_tables.py View 1 chunk +0 lines, -88 lines 0 comments Download
D trunk/src/third_party/liblouis/liblouis_untrusted.gyp View 1 chunk +0 lines, -183 lines 0 comments Download
D trunk/src/third_party/liblouis/nacl_wrapper/liblouis_instance.h View 1 chunk +0 lines, -92 lines 0 comments Download
D trunk/src/third_party/liblouis/nacl_wrapper/liblouis_instance.cc View 1 chunk +0 lines, -323 lines 0 comments Download
D trunk/src/third_party/liblouis/nacl_wrapper/liblouis_module.h View 1 chunk +0 lines, -39 lines 0 comments Download
D trunk/src/third_party/liblouis/nacl_wrapper/liblouis_module.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D trunk/src/third_party/liblouis/nacl_wrapper/liblouis_wrapper.h View 1 chunk +0 lines, -58 lines 0 comments Download
D trunk/src/third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D trunk/src/third_party/liblouis/nacl_wrapper/liblouis_wrapper_browsertest.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D trunk/src/third_party/liblouis/nacl_wrapper/translation_params.h View 1 chunk +0 lines, -32 lines 0 comments Download
D trunk/src/third_party/liblouis/nacl_wrapper/translation_result.h View 1 chunk +0 lines, -33 lines 0 comments Download
D trunk/src/third_party/liblouis/overrides/liblouis/compileTranslationTable.c View 1 chunk +0 lines, -5219 lines 0 comments Download
D trunk/src/third_party/liblouis/overrides/liblouis/config.h View 1 chunk +0 lines, -18 lines 0 comments Download
D trunk/src/third_party/liblouis/overrides/liblouis/liblouis.h View 1 chunk +0 lines, -146 lines 0 comments Download
D trunk/src/third_party/liblouis/overrides/tables/braille-patterns.cti View 1 chunk +0 lines, -287 lines 0 comments Download
D trunk/src/third_party/liblouis/overrides/tables/da.ctb View 1 chunk +0 lines, -280 lines 0 comments Download
D trunk/src/third_party/liblouis/tables.json View 1 chunk +0 lines, -398 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ckocagil
7 years ago (2013-11-28 04:54:34 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r237670 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698