Build liblouis_nacl using gyp.

Build liblouis_nacl using gyp.

Tries to reland 237638 after fixing compiler warnings from a more recent compiler used on arm.

This cl ports the nacl wrapper to the chromium build system and adds local modifications from Chromevox to liblouis. The native library and braille tables are copied to the location in the resources output directory where chromevox can pick them up.

BUG=316353
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237638

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238548

[Peter Lundblad, 2013-11-22 00:32:15]

Hi,

The bulk of this cl when counting lines is override files for liblouis. I
recommend either not looking at them or manually diffing them against the
originals in the  src directory.
Also, there's a wrapper library for native client and pepper. I modified this
minimally for now.

The added browser test is basic, we have more elaborate tests in the chromevox
codebase that I'd like to port later.

Thanks,
//Peter

[David Tseng, 2013-11-22 23:15:41]

LGTM


On Thu, Nov 21, 2013 at 4:32 PM, <plundblad@chromium.org> wrote:

> Reviewers: Dominic Mazzoni, David Tseng,
>
> Message:
> Hi,
>
> The bulk of this cl when counting lines is override files for liblouis. I
> recommend either not looking at them or manually diffing them against the
> originals in the  src directory.
> Also, there's a wrapper library for native client and pepper. I modified
> this
> minimally for now.
>
> The added browser test is basic, we have more elaborate tests in the
> chromevox
> codebase that I'd like to port later.
>
> Thanks,
> //Peter
>
> Description:
> Build liblouis_nacl using gyp.
>
> This cl ports the nacl wrapper to the chromium build system and adds local
> modifications from Chromevox to liblouis. The native library and braille
> tables
> are copied to the location in the resources output directory where
> chromevox can
> pick them up.
>
> BUG=316353
>
> Please review this at https://codereview.chromium.org/67283007/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@lkgr
>
> Affected files (+7573, -5 lines):
>   M build/gyp_chromium
>   M chrome/chrome_tests.gypi
>   A + chrome/test/data/chromeos/liblouis_nacl/manifest.json
>   A chrome/test/data/chromeos/liblouis_nacl/test.js
>   M third_party/liblouis/README.chromium
>   A third_party/liblouis/liblouis_list_tables.py
>   A third_party/liblouis/liblouis_untrusted.gyp
>   A third_party/liblouis/nacl_wrapper/liblouis_instance.h
>   A third_party/liblouis/nacl_wrapper/liblouis_instance.cc
>   A third_party/liblouis/nacl_wrapper/liblouis_module.h
>   A third_party/liblouis/nacl_wrapper/liblouis_module.cc
>   A third_party/liblouis/nacl_wrapper/liblouis_wrapper.h
>   A third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc
>   A third_party/liblouis/nacl_wrapper/liblouis_wrapper_browsertest.cc
>   A third_party/liblouis/nacl_wrapper/translation_params.h
>   A third_party/liblouis/nacl_wrapper/translation_result.h
>   A third_party/liblouis/overrides/liblouis/compileTranslationTable.c
>   A third_party/liblouis/overrides/liblouis/config.h
>   A third_party/liblouis/overrides/liblouis/liblouis.h
>   A third_party/liblouis/overrides/tables/braille-patterns.cti
>   A third_party/liblouis/overrides/tables/da.ctb
>   A third_party/liblouis/tables.json
>
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2013-11-25 17:29:36]

lgtm

https://codereview.chromium.org/67283007/diff/380001/chrome/test/data/chromeo...
File chrome/test/data/chromeos/liblouis_nacl/manifest.json (right):

https://codereview.chromium.org/67283007/diff/380001/chrome/test/data/chromeo...
chrome/test/data/chromeos/liblouis_nacl/manifest.json:3: "name": "libloi_nacl
tests",
libloi -> liblouis

https://codereview.chromium.org/67283007/diff/380001/chrome/test/data/chromeo...
File chrome/test/data/chromeos/liblouis_nacl/test.js (right):

https://codereview.chromium.org/67283007/diff/380001/chrome/test/data/chromeo...
chrome/test/data/chromeos/liblouis_nacl/test.js:25: console.log("liblouis
loaded")
nit: trailing semicolon

https://codereview.chromium.org/67283007/diff/380001/third_party/liblouis/lib...
File third_party/liblouis/liblouis_untrusted.gyp (right):

https://codereview.chromium.org/67283007/diff/380001/third_party/liblouis/lib...
third_party/liblouis/liblouis_untrusted.gyp:30:
'../..//build/common_untrusted.gypi',
double-slash before "build"

https://codereview.chromium.org/67283007/diff/380001/third_party/liblouis/lib...
third_party/liblouis/liblouis_untrusted.gyp:54: 'overrides/liblouis/cofnig.h',
cofnig -> config

https://codereview.chromium.org/67283007/diff/380001/third_party/liblouis/lib...
third_party/liblouis/liblouis_untrusted.gyp:95:
'nacl_wrapper/translation_params.h',
sort these

https://codereview.chromium.org/67283007/diff/380001/third_party/liblouis/lib...
third_party/liblouis/liblouis_untrusted.gyp:112:
'../../native_client/tools.gyp:prep_toolchain',
sort these

[plundblad, 2013-11-25 23:00:09]

dmazzoni@chromium.org writes:
> lgtm
> 
> 
> 
> 
>
https://codereview.chromium.org/67283007/diff/380001/chrome/test/data/chromeo...
> File chrome/test/data/chromeos/liblouis_nacl/manifest.json (right):
> 
>
https://codereview.chromium.org/67283007/diff/380001/chrome/test/data/chromeo...
> chrome/test/data/chromeos/liblouis_nacl/manifest.json:3: "name":
> "libloi_nacl tests",
> libloi -> liblouis
> 
>
https://codereview.chromium.org/67283007/diff/380001/chrome/test/data/chromeo...
> File chrome/test/data/chromeos/liblouis_nacl/test.js (right):
> 
>
https://codereview.chromium.org/67283007/diff/380001/chrome/test/data/chromeo...
> chrome/test/data/chromeos/liblouis_nacl/test.js:25:
> console.log("liblouis loaded")
> nit: trailing semicolon

Done.

>
https://codereview.chromium.org/67283007/diff/380001/third_party/liblouis/lib...
> File third_party/liblouis/liblouis_untrusted.gyp (right):
> 
>
https://codereview.chromium.org/67283007/diff/380001/third_party/liblouis/lib...
> third_party/liblouis/liblouis_untrusted.gyp:30:
> '../..//build/common_untrusted.gypi',
> double-slash before "build"

Done.

>
https://codereview.chromium.org/67283007/diff/380001/third_party/liblouis/lib...
> third_party/liblouis/liblouis_untrusted.gyp:54:
> 'overrides/liblouis/cofnig.h',
> cofnig -> config

Done.

>
https://codereview.chromium.org/67283007/diff/380001/third_party/liblouis/lib...
> third_party/liblouis/liblouis_untrusted.gyp:95:
> 'nacl_wrapper/translation_params.h',
> sort these

Done.

>
https://codereview.chromium.org/67283007/diff/380001/third_party/liblouis/lib...
> third_party/liblouis/liblouis_untrusted.gyp:112:
> '../../native_client/tools.gyp:prep_toolchain',
> sort these

Done.

> https://codereview.chromium.org/67283007/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Lundblad, 2013-11-27 04:56:45]

+maruel, could you please have a llok at chrome/browser_tests.isolate.?

[M-A Ruel, 2013-11-27 13:25:26]

On 2013/11/27 04:56:45, Peter Lundblad wrote:
> +maruel, could you please have a llok at chrome/browser_tests.isolate.?

perfect, lgtm

[commit-bot: I haz the power, 2013-11-27 18:03:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/plundblad@chromium.org/67283007/790001

[commit-bot: I haz the power, 2013-11-27 23:05:51]

Change committed as 237638

[commit-bot: I haz the power, 2013-12-03 23:35:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/plundblad@chromium.org/67283007/860001

[commit-bot: I haz the power, 2013-12-04 03:34:59]

Change committed as 238548

[M-A Ruel, 2014-01-30 15:27:21]

https://codereview.chromium.org/67283007/diff/860001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/67283007/diff/860001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:1673: ['OS=="linux"', {
Are you sure the embedded conditions are right. It doesn't seem to work
properly;

http://build.chromium.org/p/chromium.swarm/builders/Linux%20Isolate%20Tests/b...

MappingError:
/mnt/data/b/build/slave/chromium-linux-isolate/build/src/out/Release/chromevox_test_data/
is not a directory but ends with "/"

Please fix ASAP.

[Peter Lundblad, 2014-01-30 19:01:19]

maruel@chromium.org writes:
> 
> https://codereview.chromium.org/67283007/diff/860001/chrome/chrome_tests.gypi
> File chrome/chrome_tests.gypi (right):
> 
>
https://codereview.chromium.org/67283007/diff/860001/chrome/chrome_tests.gypi...
> chrome/chrome_tests.gypi:1673: ['OS=="linux"', {
> Are you sure the embedded conditions are right. It doesn't seem to work
> properly;
> 
>
http://build.chromium.org/p/chromium.swarm/builders/Linux%20Isolate%20Tests/b...
> 
> MappingError:
>
/mnt/data/b/build/slave/chromium-linux-isolate/build/src/out/Release/chromevox_test_data/
> is not a directory but ends with "/"
> 
> Please fix ASAP.

The error is in a different CL that was submitted a few days ago.
See http://code.google.com/p/chromium/issues/detail?id=338749 for the fix.

> https://codereview.chromium.org/67283007/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.