Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 937803002: Add a new histogram Net.QuicSession.HeadersStreamEarlyFramesReceived (Closed)

Created:
5 years, 10 months ago by Ryan Hamilton
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new histogram Net.QuicSession.HeadersStreamEarlyFramesReceived for tracking the frames received on the headers stream which arrived early. Committed: https://crrev.com/7cde50e9d748c56c8c2b1a99d00816df810a6df3 Cr-Commit-Position: refs/heads/master@{#316916}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M net/quic/quic_connection_logger.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_connection_logger_unittest.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M net/quic/quic_session.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Ryan Hamilton
5 years, 10 months ago (2015-02-18 18:58:33 UTC) #2
ramant (doing other things)
lgtm
5 years, 10 months ago (2015-02-18 19:08:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937803002/1
5 years, 10 months ago (2015-02-18 19:27:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/43587)
5 years, 10 months ago (2015-02-18 19:35:35 UTC) #7
Ryan Hamilton
+asvitkine: histograms.xml
5 years, 10 months ago (2015-02-18 19:41:12 UTC) #9
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/937803002/diff/1/net/quic/quic_connection_logger.cc File net/quic/quic_connection_logger.cc (right): https://codereview.chromium.org/937803002/diff/1/net/quic/quic_connection_logger.cc#newcode372 net/quic/quic_connection_logger.cc:372: UMA_HISTOGRAM_COUNTS("Net.QuicSession.HeadersStreamEarlyFramesReceived", Optional nit: Maybe more readable if you ...
5 years, 10 months ago (2015-02-18 19:53:55 UTC) #10
Ryan Hamilton
Thanks https://codereview.chromium.org/937803002/diff/1/net/quic/quic_connection_logger.cc File net/quic/quic_connection_logger.cc (right): https://codereview.chromium.org/937803002/diff/1/net/quic/quic_connection_logger.cc#newcode372 net/quic/quic_connection_logger.cc:372: UMA_HISTOGRAM_COUNTS("Net.QuicSession.HeadersStreamEarlyFramesReceived", On 2015/02/18 19:53:55, Alexei Svitkine wrote: > ...
5 years, 10 months ago (2015-02-18 19:57:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937803002/20001
5 years, 10 months ago (2015-02-18 19:58:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/60050)
5 years, 10 months ago (2015-02-18 20:19:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937803002/40001
5 years, 10 months ago (2015-02-18 22:00:31 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-18 23:33:16 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 23:33:48 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7cde50e9d748c56c8c2b1a99d00816df810a6df3
Cr-Commit-Position: refs/heads/master@{#316916}

Powered by Google App Engine
This is Rietveld 408576698