Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: net/quic/quic_connection_logger_unittest.cc

Issue 937803002: Add a new histogram Net.QuicSession.HeadersStreamEarlyFramesReceived (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_connection_logger.cc ('k') | net/quic/quic_session.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_connection_logger.h" 5 #include "net/quic/quic_connection_logger.h"
6 6
7 #include "net/quic/quic_protocol.h" 7 #include "net/quic/quic_protocol.h"
8 #include "net/quic/test_tools/quic_test_utils.h"
8 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
9 10
10 namespace net { 11 namespace net {
11 namespace test { 12 namespace test {
12 13
13 class QuicConnectionLoggerPeer { 14 class QuicConnectionLoggerPeer {
14 public: 15 public:
15 static size_t num_truncated_acks_sent(const QuicConnectionLogger& logger) { 16 static size_t num_truncated_acks_sent(const QuicConnectionLogger& logger) {
16 return logger.num_truncated_acks_sent_; 17 return logger.num_truncated_acks_sent_;
17 } 18 }
18 }; 19 };
19 20
20 class QuicConnectionLoggerTest : public ::testing::Test { 21 class QuicConnectionLoggerTest : public ::testing::Test {
21 protected: 22 protected:
22 QuicConnectionLoggerTest() : logger_(nullptr, net_log_) {} 23 QuicConnectionLoggerTest()
24 : session_(new MockConnection(false)), logger_(&session_, net_log_) {}
23 25
24 BoundNetLog net_log_; 26 BoundNetLog net_log_;
27 MockSession session_;
25 QuicConnectionLogger logger_; 28 QuicConnectionLogger logger_;
26 }; 29 };
27 30
28 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSentNotChanged) { 31 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSentNotChanged) {
29 QuicAckFrame frame; 32 QuicAckFrame frame;
30 logger_.OnFrameAddedToPacket(QuicFrame(&frame)); 33 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
31 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_)); 34 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
32 35
33 for (QuicPacketSequenceNumber i = 0; i < 256; ++i) { 36 for (QuicPacketSequenceNumber i = 0; i < 256; ++i) {
34 frame.missing_packets.insert(i); 37 frame.missing_packets.insert(i);
35 } 38 }
36 logger_.OnFrameAddedToPacket(QuicFrame(&frame)); 39 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
37 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_)); 40 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
38 } 41 }
39 42
40 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSent) { 43 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSent) {
41 QuicAckFrame frame; 44 QuicAckFrame frame;
42 for (QuicPacketSequenceNumber i = 0; i < 512; i += 2) { 45 for (QuicPacketSequenceNumber i = 0; i < 512; i += 2) {
43 frame.missing_packets.insert(i); 46 frame.missing_packets.insert(i);
44 } 47 }
45 logger_.OnFrameAddedToPacket(QuicFrame(&frame)); 48 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
46 EXPECT_EQ(1u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_)); 49 EXPECT_EQ(1u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
47 } 50 }
48 51
49 } // namespace test 52 } // namespace test
50 } // namespace net 53 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_connection_logger.cc ('k') | net/quic/quic_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698