Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/browser/profiles/profile_manager.h

Issue 937713003: Add several new TRACE call and UMA metrics for GetProfile() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: noms asvitkine comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_manager.h
diff --git a/chrome/browser/profiles/profile_manager.h b/chrome/browser/profiles/profile_manager.h
index c16b6df8736a59c25eccfc0b8a68ef5fd76339b6..dba8453d6bf90dafc02a908b2a5e28c7a7ae7a02 100644
--- a/chrome/browser/profiles/profile_manager.h
+++ b/chrome/browser/profiles/profile_manager.h
@@ -256,6 +256,10 @@ class ProfileManager : public base::NonThreadSafe,
// Returns true if the profile was added, false otherwise.
bool AddProfile(Profile* profile);
+ // Synchronously Creates and returns a profile. This handles both the full
Alexei Svitkine (slow) 2015/02/19 14:44:59 Nit: Don't capitalize creates.
rkaplow 2015/02/19 15:42:51 Done.
+ // creation the management.
Alexei Svitkine (slow) 2015/02/19 14:44:59 I don't understand this sentence. "This handles bo
rkaplow 2015/02/19 15:42:51 lost an "and" there in the editing. Added a bit mo
+ Profile* CreateAndInitializeProfile(const base::FilePath& profile_dir);
+
// Schedules the profile at the given path to be deleted on shutdown.
void FinishDeletingProfile(const base::FilePath& profile_dir);

Powered by Google App Engine
This is Rietveld 408576698