Add several new TRACE call and UMA metrics for GetProfile()

chrome/browser/profiles/profile_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class keeps track of the currently-active profiles in the runtime.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 
 #include <list>
@@ skipping 238 matching lines @@
   // The profile used can be overridden by using --login-profile on cros.
   Profile* GetActiveUserOrOffTheRecordProfileFromPath(
                const base::FilePath& user_data_dir);
 
   // Adds a pre-existing Profile object to the set managed by this
   // ProfileManager. This ProfileManager takes ownership of the Profile.
   // The Profile should not already be managed by this ProfileManager.
   // Returns true if the profile was added, false otherwise.
   bool AddProfile(Profile* profile);
 
+  // Synchronously Creates and returns a profile. This handles both the full

[Alexei Svitkine (slow), 2015/02/19 14:44:59]

Nit: Don't capitalize creates.

[rkaplow, 2015/02/19 15:42:51]

Done.

+  // creation the management.

[Alexei Svitkine (slow), 2015/02/19 14:44:59]

I don't understand this sentence. "This handles both the full creation the
management."? Is there a word missing?

Also, I'm not sure what "management" means in this context.

[rkaplow, 2015/02/19 15:42:51]

lost an "and" there in the editing. Added a bit more detail.

+  Profile* CreateAndInitializeProfile(const base::FilePath& profile_dir);
+
   // Schedules the profile at the given path to be deleted on shutdown.
   void FinishDeletingProfile(const base::FilePath& profile_dir);
 
   // Registers profile with given info. Returns pointer to created ProfileInfo
   // entry.
   ProfileInfo* RegisterProfile(Profile* profile, bool created);
 
   // Returns ProfileInfo associated with given |path|, registred earlier with
   // RegisterProfile.
   ProfileInfo* GetProfileInfoByPath(const base::FilePath& path) const;
@@ skipping 91 matching lines @@
 class ProfileManagerWithoutInit : public ProfileManager {
  public:
   explicit ProfileManagerWithoutInit(const base::FilePath& user_data_dir);
 
  protected:
   void DoFinalInitForServices(Profile*, bool) override {}
   void DoFinalInitLogging(Profile*) override {}
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_