Add Data Saver support to Cronet

components/cronet/android/cronet_url_request_context_adapter.h

Index: components/cronet/android/cronet_url_request_context_adapter.h
diff --git a/components/cronet/android/cronet_url_request_context_adapter.h b/components/cronet/android/cronet_url_request_context_adapter.h
index d20c02fc861a8f8f58c165b65b930b461350fc98..a5859c7b2220dcfd3e5569ebc6118e44db25361c 100644
--- a/components/cronet/android/cronet_url_request_context_adapter.h
+++ b/components/cronet/android/cronet_url_request_context_adapter.h
@@ -29,6 +29,7 @@ class ProxyConfigService;
 
 namespace cronet {
 
+class CronetDataReductionProxy;
 struct URLRequestContextConfig;
 
 bool CronetUrlRequestContextAdapterRegisterJni(JNIEnv* env);
@@ -98,6 +99,7 @@ class CronetURLRequestContextAdapter {
   std::queue<base::Closure> tasks_waiting_for_context_;
   bool is_context_initialized_;
   int default_load_flags_;
+  scoped_ptr<CronetDataReductionProxy> data_reduction_proxy_;

[mmenke, 2015/05/07 20:22:18]

BUG:  For proper teardown, we need to delete whatever object owns the URLFetcher
*before* the URLRequestContext.  Since the context owns the DRP's
NetworkDelegate, it has to be safe to delete this before the NetworkDelegate.

Alternatively, you could just cancel any probe requests before destroying the
context (Optionally deleting just the "UI" part of the data structure), and
everything will work out file.

[mmenke, 2015/05/07 20:39:52]

Test suggestion:  In another test, use a URL that hangs eternally for the
flywheel probe URL.

MockUrlRequestJobFactory already supports such urls - use getMockUrlWithFailure
with a netError of -1.

[bengr, 2015/05/08 22:41:02]

Can you say a little more? data_reduction_proxy_ gets destroyed before context_,
and drp_ owns the DRPIOData, which owns the DRPConfig, which owns the
URLFetcher.

[bengr, 2015/05/08 22:41:02]

What would this test? And mind if we postpone to a followup CL?

 
   DISALLOW_COPY_AND_ASSIGN(CronetURLRequestContextAdapter);
 };