Add Data Saver support to Cronet

components/cronet/android/cronet_url_request_context_adapter.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_
 #define COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_
 
 #include <jni.h>
 
 #include <queue>
@@ skipping 11 matching lines @@
 }  // namespace base
 
 namespace net {
 class WriteToFileNetLogObserver;
 class URLRequestContext;
 class ProxyConfigService;
 }  // namespace net
 
 namespace cronet {
 
+class CronetDataReductionProxy;
 struct URLRequestContextConfig;
 
 bool CronetUrlRequestContextAdapterRegisterJni(JNIEnv* env);
 
 // Adapter between Java CronetUrlRequestContext and net::URLRequestContext.
 class CronetURLRequestContextAdapter {
  public:
   explicit CronetURLRequestContextAdapter(
       scoped_ptr<URLRequestContextConfig> context_config);
 
@@ skipping 49 matching lines @@
   scoped_ptr<net::URLRequestContext> context_;
   scoped_ptr<net::ProxyConfigService> proxy_config_service_;
 
   // Context config is only valid untng context is initialized.
   scoped_ptr<URLRequestContextConfig> context_config_;
 
   // A queue of tasks that need to be run after context has been initialized.
   std::queue<base::Closure> tasks_waiting_for_context_;
   bool is_context_initialized_;
   int default_load_flags_;
+  scoped_ptr<CronetDataReductionProxy> data_reduction_proxy_;

[mmenke, 2015/05/07 20:22:18]

BUG:  For proper teardown, we need to delete whatever object owns the URLFetcher
*before* the URLRequestContext.  Since the context owns the DRP's
NetworkDelegate, it has to be safe to delete this before the NetworkDelegate.

Alternatively, you could just cancel any probe requests before destroying the
context (Optionally deleting just the "UI" part of the data structure), and
everything will work out file.

[mmenke, 2015/05/07 20:39:52]

Test suggestion:  In another test, use a URL that hangs eternally for the
flywheel probe URL.

MockUrlRequestJobFactory already supports such urls - use getMockUrlWithFailure
with a netError of -1.

[bengr, 2015/05/08 22:41:02]

Can you say a little more? data_reduction_proxy_ gets destroyed before context_,
and drp_ owns the DRPIOData, which owns the DRPConfig, which owns the
URLFetcher.

[bengr, 2015/05/08 22:41:02]

What would this test? And mind if we postpone to a followup CL?

 
   DISALLOW_COPY_AND_ASSIGN(CronetURLRequestContextAdapter);
 };
 
 }  // namespace cronet
 
 #endif  // COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_