Make sure MessagePortService is used in a thread safe manner.

Added DCHECKs to all public methods of MessagePortService to make sure it is used in a thread safe manner.

BUG=459115
Committed: https://crrev.com/c2d9552dde5a7dd05dc63e744c71f497f0120306
Cr-Commit-Position: refs/heads/master@{#317178}

[sgurun-gerrit only, 2015-02-17 22:08:45]

Patchset #2 (id:20001) has been deleted

[sgurun-gerrit only, 2015-02-19 01:30:19]

sgurun@chromium.org changed reviewers:
+ creis@chromium.org

[sgurun-gerrit only, 2015-02-19 01:30:35]

On 2015/02/19 01:30:19, sgurun wrote:
> mailto:sgurun@chromium.org changed reviewers:
> + mailto:creis@chromium.org

PTAL.

[Charlie Reis, 2015-02-19 18:28:16]

Thanks, LGTM with nit.  Please list 459115 as the bug number, since we were
talking about adding DCHECKs there.

https://codereview.chromium.org/937503003/diff/60001/content/browser/message_...
File content/browser/message_port_service.cc (right):

https://codereview.chromium.org/937503003/diff/60001/content/browser/message_...
content/browser/message_port_service.cc:160: const std::vector<int>&
sent_message_port_ids) {
What about this one?  (It's private, but you added a DCHECK in the private Erase
method as well.)

[sgurun-gerrit only, 2015-02-19 22:37:57]

New patchsets have been uploaded after l-g-t-m from creis@chromium.org

[sgurun-gerrit only, 2015-02-19 22:38:12]

https://codereview.chromium.org/937503003/diff/60001/content/browser/message_...
File content/browser/message_port_service.cc (right):

https://codereview.chromium.org/937503003/diff/60001/content/browser/message_...
content/browser/message_port_service.cc:160: const std::vector<int>&
sent_message_port_ids) {
On 2015/02/19 18:28:15, Charlie Reis wrote:
> What about this one?  (It's private, but you added a DCHECK in the private
Erase
> method as well.)

good catch. removed the one on Erase() since it is probably not necessary to
annotate each method.

[sgurun-gerrit only, 2015-02-19 22:39:28]

On 2015/02/19 22:38:12, sgurun wrote:
>
https://codereview.chromium.org/937503003/diff/60001/content/browser/message_...
> File content/browser/message_port_service.cc (right):
> 
>
https://codereview.chromium.org/937503003/diff/60001/content/browser/message_...
> content/browser/message_port_service.cc:160: const std::vector<int>&
> sent_message_port_ids) {
> On 2015/02/19 18:28:15, Charlie Reis wrote:
> > What about this one?  (It's private, but you added a DCHECK in the private
> Erase
> > method as well.)
> 
> good catch. removed the one on Erase() since it is probably not necessary to
> annotate each method.

also updated the description with bug number, thanks.

[sgurun-gerrit only, 2015-02-19 22:39:33]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2015-02-19 22:40:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/937503003/80001

[commit-bot: I haz the power, 2015-02-20 00:04:05]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-02-20 00:04:41]

Patchset 4 (id:??) landed as
https://crrev.com/c2d9552dde5a7dd05dc63e744c71f497f0120306
Cr-Commit-Position: refs/heads/master@{#317178}

[kaliamoorthi, 2015-02-20 12:19:55]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/942583005/ by kaliamoorthi@chromium.org.

The reason for reverting is: This CL is suspected to cause the Win7 test (dbg)
failures..