Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: content/browser/message_port_service.cc

Issue 937503003: Make sure MessagePortService is used in a thread safe manner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address nit Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/message_port_service.cc
diff --git a/content/browser/message_port_service.cc b/content/browser/message_port_service.cc
index 3b7ef7e5eff9047c126fb259cbf406ce3a3bdfbf..9ee4d70c24490c578e3335454adb471f5249dde7 100644
--- a/content/browser/message_port_service.cc
+++ b/content/browser/message_port_service.cc
@@ -63,7 +63,7 @@ MessagePortService::~MessagePortService() {
void MessagePortService::UpdateMessagePort(int message_port_id,
MessagePortDelegate* delegate,
int routing_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -76,6 +76,7 @@ void MessagePortService::UpdateMessagePort(int message_port_id,
void MessagePortService::OnMessagePortDelegateClosing(
MessagePortDelegate* delegate) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
// Check if the (possibly) crashed process had any message ports.
for (MessagePorts::iterator iter = message_ports_.begin();
iter != message_ports_.end();) {
@@ -89,7 +90,7 @@ void MessagePortService::OnMessagePortDelegateClosing(
void MessagePortService::Create(int route_id,
MessagePortDelegate* delegate,
int* message_port_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
*message_port_id = ++next_message_port_id_;
MessagePort port;
@@ -104,6 +105,7 @@ void MessagePortService::Create(int route_id,
}
void MessagePortService::Destroy(int message_port_id) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -116,6 +118,7 @@ void MessagePortService::Destroy(int message_port_id) {
void MessagePortService::Entangle(int local_message_port_id,
int remote_message_port_id) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(local_message_port_id) ||
!message_ports_.count(remote_message_port_id)) {
NOTREACHED();
@@ -132,6 +135,7 @@ void MessagePortService::PostMessage(
int sender_message_port_id,
const base::string16& message,
const std::vector<int>& sent_message_port_ids) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(sender_message_port_id)) {
NOTREACHED();
return;
@@ -195,6 +199,7 @@ void MessagePortService::PostMessageTo(
}
void MessagePortService::QueueMessages(int message_port_id) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -211,6 +216,7 @@ void MessagePortService::QueueMessages(int message_port_id) {
void MessagePortService::SendQueuedMessages(
int message_port_id,
const QueuedMessages& queued_messages) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -240,6 +246,7 @@ void MessagePortService::SendQueuedMessages(
}
void MessagePortService::SendQueuedMessagesIfPossible(int message_port_id) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -257,6 +264,7 @@ void MessagePortService::SendQueuedMessagesIfPossible(int message_port_id) {
}
void MessagePortService::HoldMessages(int message_port_id) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -271,6 +279,7 @@ void MessagePortService::HoldMessages(int message_port_id) {
}
void MessagePortService::ClosePort(int message_port_id) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -290,6 +299,7 @@ void MessagePortService::ClosePort(int message_port_id) {
}
void MessagePortService::ReleaseMessages(int message_port_id) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698