Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 93743005: Support markdown template for html editor (Closed)

Created:
7 years ago by hukun
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Docserver: Support markdown for HTML content. R=kalman@chromium.org BUG=293681 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243980

Patch Set 1 #

Total comments: 18

Patch Set 2 : add _MaybeMarkdown #

Total comments: 8

Patch Set 3 : add more tests to markdown syntax #

Total comments: 26

Patch Set 4 : polish unittest #

Total comments: 4

Patch Set 5 : done #

Patch Set 6 : fix path without dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5347 lines, -7 lines) Patch
M chrome/common/extensions/docs/server2/app.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/build_server.py View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/content_provider.py View 1 2 3 4 5 4 chunks +29 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/content_provider_test.py View 1 2 3 3 chunks +16 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
A third_party/markdown/LICENSE View 1 1 chunk +30 lines, -0 lines 0 comments Download
A + third_party/markdown/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/markdown/README.chromium View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/markdown/__init__.py View 1 chunk +443 lines, -0 lines 0 comments Download
A third_party/markdown/__main__.py View 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/markdown/__version__.py View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/markdown/blockparser.py View 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/markdown/blockprocessors.py View 1 chunk +558 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/__init__.py View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/abbr.py View 1 chunk +96 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/admonition.py View 1 chunk +118 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/attr_list.py View 1 chunk +140 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/codehilite.py View 1 chunk +240 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/def_list.py View 1 chunk +118 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/extra.py View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/fenced_code.py View 1 chunk +161 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/footnotes.py View 1 chunk +313 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/headerid.py View 1 chunk +199 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/meta.py View 1 chunk +93 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/nl2br.py View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/sane_lists.py View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/smart_strong.py View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/tables.py View 1 chunk +100 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/toc.py View 1 chunk +221 lines, -0 lines 0 comments Download
A third_party/markdown/extensions/wikilinks.py View 1 chunk +151 lines, -0 lines 0 comments Download
A third_party/markdown/inlinepatterns.py View 1 chunk +483 lines, -0 lines 0 comments Download
A third_party/markdown/odict.py View 1 chunk +194 lines, -0 lines 0 comments Download
A third_party/markdown/postprocessors.py View 1 chunk +104 lines, -0 lines 0 comments Download
A third_party/markdown/preprocessors.py View 1 chunk +298 lines, -0 lines 0 comments Download
A third_party/markdown/serializers.py View 1 chunk +277 lines, -0 lines 0 comments Download
A third_party/markdown/treeprocessors.py View 1 chunk +360 lines, -0 lines 0 comments Download
A third_party/markdown/util.py View 1 chunk +136 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
hukun
7 years ago (2013-12-20 03:41:03 UTC) #1
not at google - send to devlin
Nice! You're going to need to write a README and OWNERS file for the markdown ...
7 years ago (2013-12-20 03:56:42 UTC) #2
hukun
https://codereview.chromium.org/93743005/diff/1/chrome/common/extensions/docs/server2/app.yaml File chrome/common/extensions/docs/server2/app.yaml (right): https://codereview.chromium.org/93743005/diff/1/chrome/common/extensions/docs/server2/app.yaml#newcode2 chrome/common/extensions/docs/server2/app.yaml:2: version: 3-0-3 Done https://codereview.chromium.org/93743005/diff/1/chrome/common/extensions/docs/server2/content_provider.py File chrome/common/extensions/docs/server2/content_provider.py (right): https://codereview.chromium.org/93743005/diff/1/chrome/common/extensions/docs/server2/content_provider.py#newcode65 chrome/common/extensions/docs/server2/content_provider.py:65: ...
7 years ago (2013-12-20 07:41:53 UTC) #3
not at google - send to devlin
you're going to need a README.chromium too https://codereview.chromium.org/93743005/diff/20001/chrome/common/extensions/docs/server2/content_provider.py File chrome/common/extensions/docs/server2/content_provider.py (right): https://codereview.chromium.org/93743005/diff/20001/chrome/common/extensions/docs/server2/content_provider.py#newcode62 chrome/common/extensions/docs/server2/content_provider.py:62: # http://pythonhosted.org/Markdown/extensions/index.html ...
7 years ago (2013-12-20 11:50:40 UTC) #4
hukun
https://codereview.chromium.org/93743005/diff/20001/chrome/common/extensions/docs/server2/content_provider.py File chrome/common/extensions/docs/server2/content_provider.py (right): https://codereview.chromium.org/93743005/diff/20001/chrome/common/extensions/docs/server2/content_provider.py#newcode62 chrome/common/extensions/docs/server2/content_provider.py:62: # http://pythonhosted.org/Markdown/extensions/index.html Done https://codereview.chromium.org/93743005/diff/20001/chrome/common/extensions/docs/server2/content_provider.py#newcode88 chrome/common/extensions/docs/server2/content_provider.py:88: self.file_system.ReadSingle(path).Get() Done https://codereview.chromium.org/93743005/diff/20001/chrome/common/extensions/docs/server2/content_provider.py#newcode95 chrome/common/extensions/docs/server2/content_provider.py:95: ...
7 years ago (2013-12-23 05:12:58 UTC) #5
not at google - send to devlin
eek I totally didn't notice this code review! ping me after a day or two ...
6 years, 11 months ago (2014-01-03 03:18:00 UTC) #6
not at google - send to devlin
https://codereview.chromium.org/93743005/diff/40001/chrome/common/extensions/docs/server2/content_provider.py File chrome/common/extensions/docs/server2/content_provider.py (right): https://codereview.chromium.org/93743005/diff/40001/chrome/common/extensions/docs/server2/content_provider.py#newcode82 chrome/common/extensions/docs/server2/content_provider.py:82: if os.path.splitext(path)[1] != '.html': use posixpath.splitext https://codereview.chromium.org/93743005/diff/40001/chrome/common/extensions/docs/server2/content_provider.py#newcode88 chrome/common/extensions/docs/server2/content_provider.py:88: md_file_name ...
6 years, 11 months ago (2014-01-03 03:21:40 UTC) #7
hukun
https://codereview.chromium.org/93743005/diff/40001/chrome/common/extensions/docs/server2/content_provider.py File chrome/common/extensions/docs/server2/content_provider.py (left): https://codereview.chromium.org/93743005/diff/40001/chrome/common/extensions/docs/server2/content_provider.py#oldcode4 chrome/common/extensions/docs/server2/content_provider.py:4: Done https://codereview.chromium.org/93743005/diff/40001/chrome/common/extensions/docs/server2/content_provider.py File chrome/common/extensions/docs/server2/content_provider.py (right): https://codereview.chromium.org/93743005/diff/40001/chrome/common/extensions/docs/server2/content_provider.py#newcode61 chrome/common/extensions/docs/server2/content_provider.py:61: # http://pythonhosted.org/Markdown/extensions/index.html ...
6 years, 11 months ago (2014-01-06 08:25:19 UTC) #8
not at google - send to devlin
lgtm https://codereview.chromium.org/93743005/diff/120001/chrome/common/extensions/docs/server2/content_provider.py File chrome/common/extensions/docs/server2/content_provider.py (right): https://codereview.chromium.org/93743005/diff/120001/chrome/common/extensions/docs/server2/content_provider.py#newcode61 chrome/common/extensions/docs/server2/content_provider.py:61: if os.path.splitext(path)[1] == '.md': posixpath.splitext https://codereview.chromium.org/93743005/diff/120001/chrome/common/extensions/docs/server2/content_provider.py#newcode98 chrome/common/extensions/docs/server2/content_provider.py:98: base, ...
6 years, 11 months ago (2014-01-07 22:36:40 UTC) #9
hukun
https://codereview.chromium.org/93743005/diff/120001/chrome/common/extensions/docs/server2/content_provider.py File chrome/common/extensions/docs/server2/content_provider.py (right): https://codereview.chromium.org/93743005/diff/120001/chrome/common/extensions/docs/server2/content_provider.py#newcode61 chrome/common/extensions/docs/server2/content_provider.py:61: if os.path.splitext(path)[1] == '.md': done On 2014/01/07 22:36:40, kalman ...
6 years, 11 months ago (2014-01-08 17:13:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hukun@chromium.org/93743005/180001
6 years, 11 months ago (2014-01-08 17:14:57 UTC) #11
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43827
6 years, 11 months ago (2014-01-08 17:44:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hukun@chromium.org/93743005/310001
6 years, 11 months ago (2014-01-09 12:31:04 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=244065
6 years, 11 months ago (2014-01-09 15:55:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hukun@chromium.org/93743005/310001
6 years, 11 months ago (2014-01-09 20:09:42 UTC) #15
commit-bot: I haz the power
Change committed as 243980
6 years, 11 months ago (2014-01-09 21:40:20 UTC) #16
skobes
6 years, 11 months ago (2014-01-09 22:57:31 UTC) #17
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/132663003/ by skobes@chromium.org.

The reason for reverting is: breaks check_licenses.

Powered by Google App Engine
This is Rietveld 408576698