Support markdown template for html editor

chrome/common/extensions/docs/server2/content_provider_test.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from cStringIO import StringIO
 import json
 import unittest
 from zipfile import ZipFile
 
 from compiled_file_system import CompiledFileSystem
 from content_provider import ContentProvider
 from file_system import FileNotFoundError
 from object_store_creator import ObjectStoreCreator
 from test_file_system import TestFileSystem
 from third_party.handlebar import Handlebar
 
-
 _REDIRECTS_JSON = json.dumps({
   'oldfile.html': 'storage.html',
   'index.html': 'https://developers.google.com/chrome',
 })
 
+def _ToMarkDownOriginalText(obj):

[not at google - send to devlin, 2014/01/03 03:18:01]

let's decide whether it's mark_down/MarkDown or markdown/Markdown.
http://en.wikipedia.org/wiki/Markdown and the website imply the latter, so let's
use that.

[hukun, 2014/01/06 08:25:19]

Done

+  markdown_text = ''
+  for text, html in obj.iteritems():
+    if markdown_text != '':
+      markdown_text += '\n'
+    markdown_text += text
+  return markdown_text
+
+def _ToCompiledMarkDownHTML(obj):
+  markdown_html = ''
+  for text, html in obj.iteritems():
+    if markdown_html != '':
+      markdown_html += '\n'
+    markdown_html += html
+  return markdown_html
+
+
+_MARK_DOWN_CONTENT = {
+  '# Header 1 #': u'<h1 id="header-1">Header 1</h1>',

[not at google - send to devlin, 2014/01/03 03:18:01]

having this as a dict is a bit odd since it means it might get out of order.
Prefer a list of tuples (or tuple-of-tuples) like

_MARKDOWN_CONTENT = (
  ('#Header 1#', u'<h1 id=..'),
  ...
)

p.s. not sure the unicode part is really necessary.

also a comment on this variable would be nice.

[hukun, 2014/01/06 08:25:19]

Done

+  '1.  Foo\n': u'<ol>\n<li>Foo</li>\n</ol>',
+  '![alt text](/path/img.jpg "Title")\n':
+      u'<p><img alt="alt text" src="/path/img.jpg" title="Title" /></p>',
+  '* Unordered item 1': '<ul>\n<li>Unordered item 1</li>\n</ul>',
+}
 
 # Test file system data which exercises many different mimetypes.
 _TEST_DATA = {
   'dir': {
     'a.txt': 'a.txt content',
     'b.txt': 'b.txt content',
     'c': {
       'd.txt': 'd.txt content',
     },
   },
   'dir2': {
     'dir3': {
       'a.txt': 'a.txt content',
       'b.txt': 'b.txt content',
       'c': {
         'd.txt': 'd.txt content',
       },
     },
   },
   'img.png': 'img.png content',
   'read.txt': 'read.txt content',
   'redirects.json': _REDIRECTS_JSON,
   'run.js': 'run.js content',
   'site.css': 'site.css content',
   'storage.html': 'storage.html content',
+  'markdown.md': _ToMarkDownOriginalText(_MARK_DOWN_CONTENT)

[not at google - send to devlin, 2014/01/03 03:18:01]

you could write this pretty simply as:

'markdown.md': '\n'.join(text for text, _ in _MARKDOWN_CONTENT)

[hukun, 2014/01/06 08:25:19]

Done

 }
 
 
 class ContentProviderUnittest(unittest.TestCase):
   def setUp(self):
     self._content_provider = self._CreateContentProvider()
 
   def _CreateContentProvider(self, supports_zip=False):
     test_file_system = TestFileSystem(_TEST_DATA)
     return ContentProvider(
@@ skipping 54 matching lines @@
   def testZip2ndLevel(self):
     zip_content_provider = self._CreateContentProvider(supports_zip=True)
     content_and_type = zip_content_provider.GetContentAndType(
         'dir2/dir3.zip').Get()
     zipfile = ZipFile(StringIO(content_and_type.content))
     content_and_type.content = zipfile.namelist()
     self._assertContent(
         ['dir3/a.txt', 'dir3/b.txt', 'dir3/c/d.txt'], 'application/zip',
         content_and_type)
 
+  def testMarkdown(self):
+    content_and_type = self._content_provider.GetContentAndType(
+        'markdown.html').Get()
+    content_and_type.content = content_and_type.content.source
+    self._assertContent(_ToCompiledMarkDownHTML(_MARK_DOWN_CONTENT),

[not at google - send to devlin, 2014/01/03 03:18:01]

_ToCompiledMarkDown on next line (like all of the other test assertions)

though see above, likewise you could write this as

self._assertContent(
    '\n'.join(md for _, md in _MARKDOWN_CONTENT), 'text/html',
    content_and_type)

[hukun, 2014/01/06 08:25:19]

Done

+        'text/html', content_and_type)
+
   def testNotFound(self):
     self.assertRaises(
         FileNotFoundError,
         self._content_provider.GetContentAndType('oops').Get)
 
 
 if __name__ == '__main__':
   unittest.main()