Clarify desired behavior of FontConfigTypeface::LegacyCreateTypeface.

Clarify desired behavior of FontConfigTypeface::LegacyCreateTypeface.

This should have no real effect on behavior, but cleans up some names
and removes an unused parameter. This is a step toward separating the
SkTypeface cache from the request cache.

Committed: https://skia.googlesource.com/skia/+/e89261609a52fe7a54a6beab803ed6d63d0c2c49

[bungeman-skia, 2015-02-18 21:04:30]

bungeman@google.com changed reviewers:
+ reed@google.com

[bungeman-skia, 2015-02-18 21:04:31]

Depends on https://codereview.chromium.org/924333003/ .

[reed2, 2015-02-18 21:22:35]

reed@chromium.org changed reviewers:
+ reed@chromium.org

[reed2, 2015-02-18 21:22:35]

lgtm

[bungeman-skia, 2015-02-19 15:14:24]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-02-19 15:15:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/936893002/20001

[commit-bot: I haz the power, 2015-02-19 15:29:32]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e89261609a52fe7a54a6beab803ed6d63d0c2c49