src/ports/SkFontConfigTypeface.h - Issue 936893002: Clarify desired behavior of FontConfigTypeface::LegacyCreateTypeface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontConfigTypeface.h

Issue 936893002: Clarify desired behavior of FontConfigTypeface::LegacyCreateTypeface. (Closed) Base URL: https://skia.googlesource.com/skia.git@typefacecache

Patch Set: Line wrapping. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ports/SkFontConfigTypeface.h

diff --git a/src/ports/SkFontConfigTypeface.h b/src/ports/SkFontConfigTypeface.h

index 7eecbf69472639844c61e4392e25ae2aadf4fe6d..74f43ed017d2d583f9c0db4377d113061f2f4afe 100644

--- a/src/ports/SkFontConfigTypeface.h

+++ b/src/ports/SkFontConfigTypeface.h

@@ -39,9 +39,7 @@ public:

return fFamilyName.equals(name);

}

- static SkTypeface* LegacyCreateTypeface(const SkTypeface* family,

- const char familyName[],

- SkTypeface::Style);

+ static SkTypeface* LegacyCreateTypeface(const char familyName[], SkTypeface::Style);

protected:

friend class SkFontHost; // hack until we can make public versions

« no previous file with comments | « src/fonts/SkFontMgr_fontconfig.cpp ('k') | src/ports/SkFontHost_fontconfig.cpp » ('j') | no next file with comments »