Connect Sky and Ganesh in SkyShell

Connect Sky and Ganesh in SkyShell

This CL contains enough plumbing for Sky to render content to the screen using
Ganesh in SkyShell. We're still missing the ability to load data off the
network.

R=eseidel@chromium.org, ojan@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/2abe84a16304ad570919ef8a681c9171af9cb253

[ojan, 2015-02-18 20:28:58]

ojan@chromium.org changed reviewers:
+ ojan@chromium.org

[ojan, 2015-02-18 20:28:59]

lgtm

[eseidel, 2015-02-18 20:55:57]

lgtm

https://codereview.chromium.org/936883002/diff/20001/sky/shell/shell.cc
File sky/shell/shell.cc (right):

https://codereview.chromium.org/936883002/diff/20001/sky/shell/shell.cc#newco...
sky/shell/shell.cc:32: g_shell = this;
nit: imo it's nicer to have the caller of new set the global.

https://codereview.chromium.org/936883002/diff/20001/sky/shell/shell.cc#newco...
sky/shell/shell.cc:38: Shell& Shell::Current() {
Current implies that it could change.  I might use Shared()?

https://codereview.chromium.org/936883002/diff/20001/sky/shell/sky_main.cc
File sky/shell/sky_main.cc (left):

https://codereview.chromium.org/936883002/diff/20001/sky/shell/sky_main.cc#ol...
sky/shell/sky_main.cc:57: base::android::ScopedJavaLocalRef<jobject>
scoped_activity(env, activity);
You mentioned you wanted to rename this to "application" instead of "activity".

https://codereview.chromium.org/936883002/diff/20001/sky/shell/sky_main.cc
File sky/shell/sky_main.cc (right):

https://codereview.chromium.org/936883002/diff/20001/sky/shell/sky_main.cc#ne...
sky/shell/sky_main.cc:66: g_shell.Get()->Init();
This can just be Shell::Init(), which creates g_shell, no?

https://codereview.chromium.org/936883002/diff/20001/sky/shell/ui/animator.h
File sky/shell/ui/animator.h (right):

https://codereview.chromium.org/936883002/diff/20001/sky/shell/ui/animator.h#...
sky/shell/ui/animator.h:27: bool frame_requested_;
You should either rename these to be more clear that they're unrelated, or
document them with a comment as to what they mean.

https://codereview.chromium.org/936883002/diff/20001/sky/shell/ui/animator.h#...
sky/shell/ui/animator.h:27: bool frame_requested_;
client_requested_frame?

https://codereview.chromium.org/936883002/diff/20001/sky/shell/ui/animator.h#...
sky/shell/ui/animator.h:28: bool frame_pending_;
started_frame_creation?

https://codereview.chromium.org/936883002/diff/20001/sky/shell/ui/engine.cc
File sky/shell/ui/engine.cc (right):

https://codereview.chromium.org/936883002/diff/20001/sky/shell/ui/engine.cc#n...
sky/shell/ui/engine.cc:62: web_view_->paint(canvas.get(), blink::WebRect(0, 0,
physical_size_.width(),
blink::WebRect(gfx::Rect(physical_size))

https://codereview.chromium.org/936883002/diff/20001/sky/shell/ui/engine.cc#n...
sky/shell/ui/engine.cc:72: web_view_->resize(
blink::WebSize(gfx::ScaleSize(physical_size, 1 / device_pixel_ratio))

[abarth-chromium, 2015-02-18 21:10:13]

New patchsets have been uploaded after l-g-t-m from
ojan@chromium.org,eseidel@chromium.org

[abarth-chromium, 2015-02-18 21:15:41]

Committed patchset #3 (id:40001) manually as
2abe84a16304ad570919ef8a681c9171af9cb253 (presubmit successful).