sky/shell/gpu/ganesh_context.cc - Issue 936883002: Connect Sky and Ganesh in SkyShell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/shell/gpu/ganesh_context.cc

Issue 936883002: Connect Sky and Ganesh in SkyShell (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Address review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/shell/gpu/ganesh_context.cc

diff --git a/sky/shell/gpu/ganesh_context.cc b/sky/shell/gpu/ganesh_context.cc

index 77833b34c76c828ac25cf31aa0321042a0cc2de9..6f5de8b25487439a1a8bd4184d423a31bc20b950 100644

--- a/sky/shell/gpu/ganesh_context.cc

+++ b/sky/shell/gpu/ganesh_context.cc

@@ -30,7 +30,7 @@ GaneshContext::GaneshContext(scoped_refptr<gfx::GLContext> gl_context)

gr_context_ = skia::AdoptRef(GrContext::Create(

kOpenGL_GrBackend, reinterpret_cast<GrBackendContext>(interface.get())));

- DCHECK(gr_context_);

+ DCHECK(gr_context_) << "Failed to create GrContext.";

gr_context_->setResourceCacheLimits(kMaxGaneshResourceCacheCount,

kMaxGaneshResourceCacheBytes);

}